2020-02-15 01:49:11

by Tushar Sugandhi

Subject: [PATCH v4 2/3] IMA: Add log statements for failure conditions

process_buffer_measurement() does not have log messages for failure
conditions.

This change adds a log statement in the above function.

Signed-off-by: Tushar Sugandhi <[email protected]>
Reviewed-by: Lakshmi Ramasubramanian <[email protected]>
Suggested-by: Joe Perches <[email protected]>
---
security/integrity/ima/ima_main.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9fe949c6a530..aac1c44fb11b 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -757,6 +757,9 @@ void process_buffer_measurement(const void *buf, int size,
ima_free_template_entry(entry);

out:
+ if (ret < 0)
+ pr_devel("%s: failed, result: %d\n", __func__, ret);
+
return;
}

--
2.17.1

2020-02-16 12:43:42

by Mimi Zohar

Subject: Re: [PATCH v4 2/3] IMA: Add log statements for failure conditions

On Fri, 2020-02-14 at 17:47 -0800, Tushar Sugandhi wrote:
> process_buffer_measurement() does not have log messages for failure
> conditions.
>
> This change adds a log statement in the above function.
>
> Signed-off-by: Tushar Sugandhi <[email protected]>
> Reviewed-by: Lakshmi Ramasubramanian <[email protected]>
> Suggested-by: Joe Perches <[email protected]>

Reviewed-by: Mimi Zohar <[email protected]>

> ---
> security/integrity/ima/ima_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9fe949c6a530..aac1c44fb11b 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -757,6 +757,9 @@ void process_buffer_measurement(const void *buf, int size,
> ima_free_template_entry(entry);
>
> out:
> + if (ret < 0)
> + pr_devel("%s: failed, result: %d\n", __func__, ret);
> +
> return;
> }
>