2020-02-17 14:14:33

by Prarit Bhargava

Subject: [PATCH] EDAC/mce_amd: Output Scalable MCA processor warning once

This warning is output for every virtual cpu in a guest on an EPYC 2
system. The warning only needs to be logged one time.

Output the warning only once.

Signed-off-by: Prarit Bhargava <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: James Morse <[email protected]>
Cc: Robert Richter <[email protected]>
Cc: [email protected]
---
drivers/edac/mce_amd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index ea980c556f2e..8874b7722b2f 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -1239,7 +1239,7 @@ static int __init mce_amd_init(void)

case 0x17:
case 0x18:
- pr_warn("Decoding supported only on Scalable MCA processors.\n");
+ pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
return -EINVAL;

default:
--
2.21.1

2020-02-18 16:29:10

by Borislav Petkov

Subject: Re: [PATCH] EDAC/mce_amd: Output Scalable MCA processor warning once

On Mon, Feb 17, 2020 at 08:46:27AM -0500, Prarit Bhargava wrote:
> This warning is output for every virtual cpu in a guest on an EPYC 2
> system. The warning only needs to be logged one time.
>
> Output the warning only once.
>
> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Tony Luck <[email protected]>
> Cc: James Morse <[email protected]>
> Cc: Robert Richter <[email protected]>
> Cc: [email protected]
> ---
> drivers/edac/mce_amd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> index ea980c556f2e..8874b7722b2f 100644
> --- a/drivers/edac/mce_amd.c
> +++ b/drivers/edac/mce_amd.c
> @@ -1239,7 +1239,7 @@ static int __init mce_amd_init(void)
>
> case 0x17:
> case 0x18:
> - pr_warn("Decoding supported only on Scalable MCA processors.\n");
> + pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
> return -EINVAL;
>
> default:
> --

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette