When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
.../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
.../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
Reported-by: kbuild test robot <[email protected]>
Reported-by: patchwork-bot+linux-amlogic<[email protected]>
Reported-by: Stephen Rothwell<[email protected]>
Signed-off-by: Jianxin Pan <[email protected]>
---
drivers/soc/amlogic/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
index 6cb06e7..321c5e2 100644
--- a/drivers/soc/amlogic/Kconfig
+++ b/drivers/soc/amlogic/Kconfig
@@ -50,7 +50,7 @@ config MESON_EE_PM_DOMAINS
config MESON_SECURE_PM_DOMAINS
bool "Amlogic Meson Secure Power Domains driver"
- depends on ARCH_MESON || COMPILE_TEST
+ depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
depends on PM && OF
depends on HAVE_ARM_SMCCC
default ARCH_MESON
--
2.7.4
Hi Jianxin,
On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <[email protected]> wrote:
>
> When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
> .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
> .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
>
> Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
>
> Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
>
> Reported-by: kbuild test robot <[email protected]>
> Reported-by: patchwork-bot+linux-amlogic<[email protected]>
> Reported-by: Stephen Rothwell<[email protected]>
> Signed-off-by: Jianxin Pan <[email protected]>
> ---
> drivers/soc/amlogic/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I will apply that patch to linux-next today.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <[email protected]> wrote:
> >
> > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
> > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
> > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
> >
> > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
> >
> > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
> >
> > Reported-by: kbuild test robot <[email protected]>
> > Reported-by: patchwork-bot+linux-amlogic<[email protected]>
> > Reported-by: Stephen Rothwell<[email protected]>
> > Signed-off-by: Jianxin Pan <[email protected]>
> > ---
> > drivers/soc/amlogic/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I will apply that patch to linux-next today.
This fixes the build for me.
Tested-by: Stephen Rothwell<[email protected]>
Also, please keep the commit message tags together at the end of the
commit message i.e. remove the blank line after the Fixes: tag above.
(see "git interpret-trailers ")
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <[email protected]> wrote:
> > >
> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
> > >
> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
> > >
> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
> > >
> > > Reported-by: kbuild test robot <[email protected]>
> > > Reported-by: patchwork-bot+linux-amlogic<[email protected]>
> > > Reported-by: Stephen Rothwell<[email protected]>
> > > Signed-off-by: Jianxin Pan <[email protected]>
> > > ---
> > > drivers/soc/amlogic/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I will apply that patch to linux-next today.
>
> This fixes the build for me.
>
> Tested-by: Stephen Rothwell<[email protected]>
>
> Also, please keep the commit message tags together at the end of the
> commit message i.e. remove the blank line after the Fixes: tag above.
> (see "git interpret-trailers ")
I am still applying this patch ...
--
Cheers,
Stephen Rothwell
Stephen Rothwell <[email protected]> writes:
> Hi all,
>
> On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <[email protected]> wrote:
>> >
>> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <[email protected]> wrote:
>> > >
>> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
>> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
>> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
>> > >
>> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
>> > >
>> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
>> > >
>> > > Reported-by: kbuild test robot <[email protected]>
>> > > Reported-by: patchwork-bot+linux-amlogic<[email protected]>
>> > > Reported-by: Stephen Rothwell<[email protected]>
>> > > Signed-off-by: Jianxin Pan <[email protected]>
>> > > ---
>> > > drivers/soc/amlogic/Kconfig | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > I will apply that patch to linux-next today.
>>
>> This fixes the build for me.
>>
>> Tested-by: Stephen Rothwell<[email protected]>
>>
>> Also, please keep the commit message tags together at the end of the
>> commit message i.e. remove the blank line after the Fixes: tag above.
>> (see "git interpret-trailers ")
>
> I am still applying this patch ...
I've fixed up the trailer whitespace an queued this up now, so should
show up in linux next shortly.
Kevin
Hi Kevin,
On Sat, 29 Feb 2020 17:55:32 +0100 Kevin Hilman <[email protected]> wrote:
>
> I've fixed up the trailer whitespace an queued this up now, so should
> show up in linux next shortly.
Thanks.
--
Cheers,
Stephen Rothwell