2020-02-18 08:51:56

by Martin Kepplinger

Subject: [PATCH v2 0/9] arm64: dts: librem5-devkit: description updates

These are additions to the imx8mq-librem5-devkit devicetree description
we are running for quite some time. All users should have them:

revision history
----------------
v2: review by Shawn and Guido: remove a battery description
add SoB tags, coding style fixes, squash and reorder audio
descritions, remove redundant and unneeded changes.
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

Angus Ainslie (Purism) (8):
arm64: dts: librem5-devkit: add sai2 and sai6 pinctrl definitions
arm64: dts: librem5-devkit: enable sai2 and sai6 audio interface
arm64: dts: librem5-devkit: add the simcom 7100 modem and sgtl5000
audio codec
arm64: dts: librem5-devkit: allow modem to wake the system from
suspend
arm64: dts: librem5-devkit: add a vbus supply to usb0
arm64: dts: librem5-devkit: add the regulators for DVFS
arm64: dts: librem5-devkit: allow the redpine card to be removed
arm64: dts: librem5-devkit: increase the VBUS current in the kernel

Martin Kepplinger (1):
arm64: dts: librem5-devkit: add lsm9ds1 mount matrix

.../dts/freescale/imx8mq-librem5-devkit.dts | 134 +++++++++++++++++-
1 file changed, 131 insertions(+), 3 deletions(-)

--
2.20.1

2020-02-18 08:52:03

by Martin Kepplinger

Subject: [PATCH v2 3/9] arm64: dts: librem5-devkit: add the simcom 7100 modem and sgtl5000 audio codec

From: "Angus Ainslie (Purism)" <[email protected]>

Add the simcomm modem and the sgtl5000 audio codec.

Signed-off-by: Angus Ainslie (Purism) <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
.../dts/freescale/imx8mq-librem5-devkit.dts | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 25135b08d4f8..ec12477d925d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -148,6 +148,53 @@
regulator-always-on;
};

+ wwan_codec: sound-wwan-codec {
+ compatible = "option,gtm601";
+ #sound-dai-cells = <0>;
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "sgtl5000";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "Speaker Ext",
+ "Line", "Line In Jack";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "Microphone Jack", "Mic Bias",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "Speaker Ext", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai2>;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&audio_codec>;
+ clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
+ frame-master;
+ bitclock-master;
+ };
+ };
+
+ sound-wwan {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "SIMCom SIM7100";
+ simple-audio-card,format = "dsp_a";
+ simple-audio-card,cpu {
+ sound-dai = <&sai6>;
+ };
+ telephony_link_master: simple-audio-card,codec {
+ sound-dai = <&wwan_codec>;
+ frame-master;
+ bitclock-master;
+ };
+ };
+
vibrator {
compatible = "gpio-vibrator";
pinctrl-names = "default";
@@ -426,6 +473,19 @@
vddio-supply = <&reg_3v3_p>;
};

+ audio_codec: sgtl5000@a {
+ compatible = "fsl,sgtl5000";
+ clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
+ assigned-clocks = <&clk IMX8MQ_CLK_SAI2>;
+ assigned-clock-parents = <&clk IMX8MQ_AUDIO_PLL1_OUT>;
+ assigned-clock-rates = <24576000>;
+ #sound-dai-cells = <0>;
+ reg = <0x0a>;
+ VDDD-supply = <&reg_1v8_p>;
+ VDDIO-supply = <&reg_3v3_p>;
+ VDDA-supply = <&reg_3v3_p>;
+ };
+
touchscreen@5d {
compatible = "goodix,gt5688";
reg = <0x5d>;
--
2.20.1

2020-02-18 08:52:54

by Martin Kepplinger

Subject: [PATCH v2 8/9] arm64: dts: librem5-devkit: increase the VBUS current in the kernel

From: "Angus Ainslie (Purism)" <[email protected]>

The poly fuses can handle 6V 4Amps so incease the kernel limts to 5V
3.5Amps.

Signed-off-by: Angus Ainslie (Purism) <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 8071e6a34604..4cb11ed17c24 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -426,10 +426,10 @@
PDO_FIXED_USB_COMM |
PDO_FIXED_DUAL_ROLE |
PDO_FIXED_DATA_SWAP )>;
- sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM |
+ sink-pdos = <PDO_FIXED(5000, 3500, PDO_FIXED_USB_COMM |
PDO_FIXED_DUAL_ROLE |
PDO_FIXED_DATA_SWAP )
- PDO_VAR(5000, 3000, 3000)>;
+ PDO_VAR(5000, 5000, 3500)>;
op-sink-microwatt = <10000000>;

ports {
--
2.20.1

2020-02-24 02:01:45

by Shawn Guo

Subject: Re: [PATCH v2 3/9] arm64: dts: librem5-devkit: add the simcom 7100 modem and sgtl5000 audio codec

On Tue, Feb 18, 2020 at 09:49:36AM +0100, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <[email protected]>
>
> Add the simcomm modem and the sgtl5000 audio codec.
>
> Signed-off-by: Angus Ainslie (Purism) <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
> .../dts/freescale/imx8mq-librem5-devkit.dts | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 25135b08d4f8..ec12477d925d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -148,6 +148,53 @@
> regulator-always-on;
> };
>
> + wwan_codec: sound-wwan-codec {
> + compatible = "option,gtm601";
> + #sound-dai-cells = <0>;
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "sgtl5000";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "Speaker Ext",
> + "Line", "Line In Jack";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "Microphone Jack", "Mic Bias",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "Speaker Ext", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&audio_codec>;
> + clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> + frame-master;
> + bitclock-master;
> + };
> + };
> +
> + sound-wwan {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "SIMCom SIM7100";
> + simple-audio-card,format = "dsp_a";

newline

> + simple-audio-card,cpu {
> + sound-dai = <&sai6>;
> + };

newline

> + telephony_link_master: simple-audio-card,codec {
> + sound-dai = <&wwan_codec>;
> + frame-master;
> + bitclock-master;
> + };
> + };
> +
> vibrator {
> compatible = "gpio-vibrator";
> pinctrl-names = "default";
> @@ -426,6 +473,19 @@
> vddio-supply = <&reg_3v3_p>;
> };
>
> + audio_codec: sgtl5000@a {

Node name needs to be generic, not the label name. So it should be:

sgtl5000: audio-codec@a {

Shawn

> + compatible = "fsl,sgtl5000";
> + clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> + assigned-clocks = <&clk IMX8MQ_CLK_SAI2>;
> + assigned-clock-parents = <&clk IMX8MQ_AUDIO_PLL1_OUT>;
> + assigned-clock-rates = <24576000>;
> + #sound-dai-cells = <0>;
> + reg = <0x0a>;
> + VDDD-supply = <&reg_1v8_p>;
> + VDDIO-supply = <&reg_3v3_p>;
> + VDDA-supply = <&reg_3v3_p>;
> + };
> +
> touchscreen@5d {
> compatible = "goodix,gt5688";
> reg = <0x5d>;
> --
> 2.20.1
>