2020-02-18 19:34:58

by Corentin LABBE

Subject: [PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name

device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index d14b2bb3f67c..cb997b82c008 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3267,7 +3267,7 @@ static struct platform_driver lpc32xx_udc_driver = {
.suspend = lpc32xx_udc_suspend,
.resume = lpc32xx_udc_resume,
.driver = {
- .name = (char *) driver_name,
+ .name = driver_name,
.of_match_table = of_match_ptr(lpc32xx_udc_of_match),
},
};
--
2.24.1

2020-02-18 19:41:30

by Alexandre Belloni

Subject: Re: [PATCH 09/20] usb: gadget: lpc32xx_udc: remove useless cast for driver.name

On 18/02/2020 19:32:52+0000, Corentin Labbe wrote:
> device_driver name is const char pointer, so it not useful to cast
> driver_name (which is already const char).
>
> Signed-off-by: Corentin Labbe <[email protected]>
Reviewed-by: Alexandre Belloni <[email protected]>

> ---
> drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
> index d14b2bb3f67c..cb997b82c008 100644
> --- a/drivers/usb/gadget/udc/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
> @@ -3267,7 +3267,7 @@ static struct platform_driver lpc32xx_udc_driver = {
> .suspend = lpc32xx_udc_suspend,
> .resume = lpc32xx_udc_resume,
> .driver = {
> - .name = (char *) driver_name,
> + .name = driver_name,
> .of_match_table = of_match_ptr(lpc32xx_udc_of_match),
> },
> };
> --
> 2.24.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com