2020-02-19 11:57:38

by Oleksandr Suvorov

Subject: [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc

SD/MMC on Colibri iMX7S/D modules successfully support
200Mhz frequency in HS200 mode.

Removing the unnecessary max-frequency limit significantly
increases the performance:

== before fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
Timing buffered disk reads: 252 MB in 3.02 seconds = 83.54 MB/sec
==================

=== after fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
Timing buffered disk reads: 408 MB in 3.00 seconds = 135.94 MB/sec
==================

Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
1GB (eMMC) support")
Signed-off-by: Oleksandr Suvorov <[email protected]>
---

arch/arm/boot/dts/imx7-colibri.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index d05be3f0e2a7..04717cf69db0 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -336,7 +336,6 @@ &usdhc3 {
assigned-clock-rates = <400000000>;
bus-width = <8>;
fsl,tuning-step = <2>;
- max-frequency = <100000000>;
vmmc-supply = <&reg_module_3v3>;
vqmmc-supply = <&reg_DCDC3>;
non-removable;
--
2.24.1

2020-02-19 12:49:15

by Fabio Estevam

Subject: Re: [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc

Hi Oleksandr,

On Wed, Feb 19, 2020 at 8:57 AM Oleksandr Suvorov
<[email protected]> wrote:
>
> SD/MMC on Colibri iMX7S/D modules successfully support
> 200Mhz frequency in HS200 mode.

s/Mhz/MHz

>
> Removing the unnecessary max-frequency limit significantly
> increases the performance:
>
> == before fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
> Timing buffered disk reads: 252 MB in 3.02 seconds = 83.54 MB/sec
> ==================
>
> === after fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
> Timing buffered disk reads: 408 MB in 3.00 seconds = 135.94 MB/sec
> ==================

Nice improvement :-)

>
> Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
> 1GB (eMMC) support")

Please keep the Fixes tag in a single line.

Reviewed-by: Fabio Estevam <[email protected]>