LinuxLists.cc - [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss

2020-02-19 14:19:51

Subject: [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss_quirk on DWC3 controller

2020-02-19 14:20:05

Subject: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS instances in park mode

In certain circumstances, the XHCI SuperSpeed instance in park mode
can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
load on the single XHCI SuperSpeed instance, the controller can crash like:
xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
usb 2-1.1-port1: cannot reset (err = -22)

Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
the issue. The bit is described as :
"When this bit is set to '1' all SS bus instances in park mode are disabled"

Synopsys explains in [1]:
The GUCTL1.PARKMODE_DISABLE_SS is only available in
dwc_usb3 controller running in host mode.
This should not be set for other IPs.
This can be disabled by default based on IP, but I recommend to have a
property to enable this feature for devices that need this.

[1] https://lore.kernel.org/linux-usb/[email protected]

CC: Dongjin Kim <[email protected]>
Cc: Jianxin Pan <[email protected]>
Cc: Thinh Nguyen <[email protected]>
Cc: Jun Li <[email protected]>
Reported-by: Tim <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/usb/dwc3/core.c | 5 +++++
drivers/usb/dwc3/core.h | 4 ++++
2 files changed, 9 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 1d85c42b9c67..43bd5b1ea9e2 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1029,6 +1029,9 @@ static int dwc3_core_init(struct dwc3 *dwc)
if (dwc->dis_tx_ipgap_linecheck_quirk)
reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS;

+ if (dwc->parkmode_disable_ss_quirk)
+ reg |= DWC3_GUCTL1_PARKMODE_DISABLE_SS;
+
dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
}

@@ -1342,6 +1345,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
"snps,dis-del-phy-power-chg-quirk");
dwc->dis_tx_ipgap_linecheck_quirk = device_property_read_bool(dev,
"snps,dis-tx-ipgap-linecheck-quirk");
+ dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev,
+ "snps,parkmode-disable-ss-quirk");

dwc->tx_de_emphasis_quirk = device_property_read_bool(dev,
"snps,tx_de_emphasis_quirk");
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 77c4a9abe365..3ecc69c5b150 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -249,6 +249,7 @@
#define DWC3_GUCTL_HSTINAUTORETRY BIT(14)

/* Global User Control 1 Register */
+#define DWC3_GUCTL1_PARKMODE_DISABLE_SS BIT(17)
#define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS BIT(28)
#define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW BIT(24)

@@ -1024,6 +1025,8 @@ struct dwc3_scratchpad_array {
* change quirk.
* @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
* check during HS transmit.
+ * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
+ * instances in park mode.
* @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
* @tx_de_emphasis: Tx de-emphasis value
* 0 - -6dB de-emphasis
@@ -1215,6 +1218,7 @@ struct dwc3 {
unsigned dis_u2_freeclk_exists_quirk:1;
unsigned dis_del_phy_power_chg_quirk:1;
unsigned dis_tx_ipgap_linecheck_quirk:1;
+ unsigned parkmode_disable_ss_quirk:1;

unsigned tx_de_emphasis_quirk:1;
unsigned tx_de_emphasis:2;
--
2.22.0

2020-02-21 02:08:11

by Jun Li

[permalink] [raw]

Subject: Re: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS instances in park mode

Neil Armstrong <[email protected]> 于2020年2月19日周三下午10:18写道：
>
> In certain circumstances, the XHCI SuperSpeed instance in park mode
> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
> load on the single XHCI SuperSpeed instance, the controller can crash like:
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
> xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
> xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
> usb 2-1.1-port1: cannot reset (err = -22)
>
> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
> the issue. The bit is described as :
> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>
> Synopsys explains in [1]:
> The GUCTL1.PARKMODE_DISABLE_SS is only available in
> dwc_usb3 controller running in host mode.
> This should not be set for other IPs.
> This can be disabled by default based on IP, but I recommend to have a
> property to enable this feature for devices that need this.
>
> [1] https://lore.kernel.org/linux-usb/[email protected]

This is not for gadget, patch title should be:

usb: dwc3: core: add support...

Li Jun

2020-02-21 09:13:56

by Neil Armstrong

[permalink] [raw]

Subject: Re: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS instances in park mode

On 21/02/2020 02:59, Jun Li wrote:
> Neil Armstrong <[email protected]> 于2020年2月19日周三下午10:18写道：
>>
>> In certain circumstances, the XHCI SuperSpeed instance in park mode
>> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
>> load on the single XHCI SuperSpeed instance, the controller can crash like:
>> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>> xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
>> xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
>> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>> hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
>> xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
>> usb 2-1.1-port1: cannot reset (err = -22)
>>
>> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
>> the issue. The bit is described as :
>> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>>
>> Synopsys explains in [1]:
>> The GUCTL1.PARKMODE_DISABLE_SS is only available in
>> dwc_usb3 controller running in host mode.
>> This should not be set for other IPs.
>> This can be disabled by default based on IP, but I recommend to have a
>> property to enable this feature for devices that need this.
>>
>> [1] https://lore.kernel.org/linux-usb/[email protected]
>
> This is not for gadget, patch title should be:
>
> usb: dwc3: core: add support...
>
> Li Jun
>

Indeed... time for a v4.

Thanks,

Neil

2020-02-21 09:14:59

by Neil Armstrong

[permalink] [raw]

Subject: Re: [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss_quirk on DWC3 controller

On 19/02/2020 15:18, Neil Armstrong wrote:
> In certain circumstances, the XHCI SuperSpeed instance in park mode
> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
> load on the single XHCI SuperSpeed instance, the controller can crash like:
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
> xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
> xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
> usb 2-1.1-port1: cannot reset (err = -22)
>
> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
> the issue. The bit is described as :
> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>
> The bug has been reproduced by Jun Li <[email protected]> and confirmed
> by Thinh Nguyen <[email protected]> with the explanation:
>> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
>> running in host mode. This should not be set for other IPs.
>> This can be disabled by default based on IP, but I recommend to have a
>> property to enable this feature for devices that need this.
>
> Changes since v2 at [2]:
> - rebased on v5.6-rc2
>
> Changes since v1 at [1]:
> - added rob review tag
> - added Thinh Nguyen in commit log
>
> [1] https://lore.kernel.org/linux-amlogic/[email protected]
> [1] https://lore.kernel.org/linux-amlogic/[email protected]
>
> Neil Armstrong (3):
> doc: dt: bindings: usb: dwc3: Update entries for disabling SS
> instances in park mode
> usb: dwc3: gadget: Add support for disabling SS instances in park mode
> arm64: dts: g12-common: add parkmode_disable_ss_quirk on DWC3
> controller
>
> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 +
> drivers/usb/dwc3/core.c | 5 +++++
> drivers/usb/dwc3/core.h | 4 ++++
> 4 files changed, 12 insertions(+)
>

Please ignore this serie, the patch 3 subject is wrong.

Neil