2020-02-20 14:10:18

by Stefano Garzarella

Subject: [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description

In the kernel we are using msecs_to_jiffies() to convert the
'sq_thread_idle' parameter, provided by the user, in jiffies.
So, the value is interpreted in milliseconds and not microseconds.

Fixes: 59bb09c553eb ("man: add io_uring_setup.2 man page")
Signed-off-by: Stefano Garzarella <[email protected]>
---
man/io_uring_setup.2 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/io_uring_setup.2 b/man/io_uring_setup.2
index 4057e4b..20c67dc 100644
--- a/man/io_uring_setup.2
+++ b/man/io_uring_setup.2
@@ -82,7 +82,7 @@ doing a single system call.

If the kernel thread is idle for more than
.I sq_thread_idle
-microseconds, it will set the
+milliseconds, it will set the
.B IORING_SQ_NEED_WAKEUP
bit in the
.I flags
--
2.24.1

2020-02-20 16:20:33

by Jens Axboe

Subject: Re: [PATCH liburing] man/io_uring_setup.2: fix 'sq_thread_idle' description

On 2/20/20 7:08 AM, Stefano Garzarella wrote:
> In the kernel we are using msecs_to_jiffies() to convert the
> 'sq_thread_idle' parameter, provided by the user, in jiffies.
> So, the value is interpreted in milliseconds and not microseconds.

Applied, thanks.

--
Jens Axboe