2020-02-21 02:56:36

by Masahiro Yamada

Subject: [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C controller to json-schema

Convert the UniPhier FIFO-builtin I2C (a.k.a. FIFO) controller binding
to DT schema format.

There are two types of I2C controllers used on the UniPhier platform.
This is the new one with FIFO support, which is used on the Pro4 SoC
or newer.

Signed-off-by: Masahiro Yamada <[email protected]>
---

.../bindings/i2c/i2c-uniphier-f.txt | 25 ----------
.../bindings/i2c/socionext,uniphier-fi2c.yaml | 50 +++++++++++++++++++
2 files changed, 50 insertions(+), 25 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt b/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
deleted file mode 100644
index 27fc6f8c798b..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-UniPhier I2C controller (FIFO-builtin)
-
-Required properties:
-- compatible: should be "socionext,uniphier-fi2c".
-- #address-cells: should be 1.
-- #size-cells: should be 0.
-- reg: offset and length of the register set for the device.
-- interrupts: a single interrupt specifier.
-- clocks: phandle to the input clock.
-
-Optional properties:
-- clock-frequency: desired I2C bus frequency in Hz. The maximum supported
- value is 400000. Defaults to 100000 if not specified.
-
-Examples:
-
- i2c0: i2c@58780000 {
- compatible = "socionext,uniphier-fi2c";
- reg = <0x58780000 0x80>;
- #address-cells = <1>;
- #size-cells = <0>;
- interrupts = <0 41 4>;
- clocks = <&i2c_clk>;
- clock-frequency = <100000>;
- };
diff --git a/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml b/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
new file mode 100644
index 000000000000..15abc022968e
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/socionext,uniphier-fi2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: UniPhier I2C controller (FIFO-builtin)
+
+maintainers:
+ - Masahiro Yamada <[email protected]>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ const: socionext,uniphier-fi2c
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-frequency:
+ minimum: 100000
+ maximum: 400000
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+ - interrupts
+ - clocks
+
+examples:
+ - |
+ i2c0: i2c@58780000 {
+ compatible = "socionext,uniphier-fi2c";
+ reg = <0x58780000 0x80>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <0 41 4>;
+ clocks = <&i2c_clk>;
+ clock-frequency = <100000>;
+ };
--
2.17.1

2020-02-26 16:50:08

by Rob Herring

Subject: Re: [PATCH 2/2] dt-bindings: i2c: Convert UniPhier FI2C controller to json-schema

On Fri, 21 Feb 2020 11:55:34 +0900, Masahiro Yamada wrote:
> Convert the UniPhier FIFO-builtin I2C (a.k.a. FIFO) controller binding
> to DT schema format.
>
> There are two types of I2C controllers used on the UniPhier platform.
> This is the new one with FIFO support, which is used on the Pro4 SoC
> or newer.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> .../bindings/i2c/i2c-uniphier-f.txt | 25 ----------
> .../bindings/i2c/socionext,uniphier-fi2c.yaml | 50 +++++++++++++++++++
> 2 files changed, 50 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier-f.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-fi2c.yaml
>

Applied, thanks.

Rob