2020-02-21 18:25:46

by Logan Gunthorpe

Subject: [PATCH v3 1/7] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions

This variable is not used anywhere and should therefore be removed
from the structure.

Signed-off-by: Logan Gunthorpe <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
---
include/linux/memory_hotplug.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
index f4d59155f3d4..69ff3037528d 100644
--- a/include/linux/memory_hotplug.h
+++ b/include/linux/memory_hotplug.h
@@ -55,11 +55,9 @@ enum {

/*
* Restrictions for the memory hotplug:
- * flags: MHP_ flags
* altmap: alternative allocator for memmap array
*/
struct mhp_restrictions {
- unsigned long flags;
struct vmem_altmap *altmap;
};

--
2.20.1

2020-02-28 21:31:49

by Dan Williams

Subject: Re: [PATCH v3 1/7] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions

On Fri, Feb 21, 2020 at 10:25 AM Logan Gunthorpe <[email protected]> wrote:
>
> This variable is not used anywhere and should therefore be removed
> from the structure.
>
> Signed-off-by: Logan Gunthorpe <[email protected]>
> Reviewed-by: David Hildenbrand <[email protected]>

Reviewed-by: Dan Williams <[email protected]>

2020-03-03 09:59:27

by Michal Hocko

Subject: Re: [PATCH v3 1/7] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions

On Fri 21-02-20 11:24:57, Logan Gunthorpe wrote:
> This variable is not used anywhere and should therefore be removed
> from the structure.
>
> Signed-off-by: Logan Gunthorpe <[email protected]>
> Reviewed-by: David Hildenbrand <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> include/linux/memory_hotplug.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index f4d59155f3d4..69ff3037528d 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -55,11 +55,9 @@ enum {
>
> /*
> * Restrictions for the memory hotplug:
> - * flags: MHP_ flags
> * altmap: alternative allocator for memmap array
> */
> struct mhp_restrictions {
> - unsigned long flags;
> struct vmem_altmap *altmap;
> };
>
> --
> 2.20.1

--
Michal Hocko
SUSE Labs