2020-02-21 19:18:59

by Heinrich Schuchardt

Subject: [PATCH 1/1] efi/libstub: error message in handle_cmdline_files()

The memory for files is allocated not reallocated.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/firmware/efi/libstub/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
index be78f64f8d80..d4c7e5f59d2c 100644
--- a/drivers/firmware/efi/libstub/file.c
+++ b/drivers/firmware/efi/libstub/file.c
@@ -190,7 +190,7 @@ static efi_status_t handle_cmdline_files(efi_loaded_image_t *image,
&alloc_addr,
hard_limit);
if (status != EFI_SUCCESS) {
- pr_efi_err("Failed to reallocate memory for files\n");
+ pr_efi_err("Failed to allocate memory for files\n");
goto err_close_file;
}

--
2.25.0

2020-02-22 17:55:05

by Ard Biesheuvel

Subject: Re: [PATCH 1/1] efi/libstub: error message in handle_cmdline_files()

On Fri, 21 Feb 2020 at 20:18, Heinrich Schuchardt <[email protected]> wrote:
>
> The memory for files is allocated not reallocated.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Queued in efi/next

Thanks,

> ---
> drivers/firmware/efi/libstub/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
> index be78f64f8d80..d4c7e5f59d2c 100644
> --- a/drivers/firmware/efi/libstub/file.c
> +++ b/drivers/firmware/efi/libstub/file.c
> @@ -190,7 +190,7 @@ static efi_status_t handle_cmdline_files(efi_loaded_image_t *image,
> &alloc_addr,
> hard_limit);
> if (status != EFI_SUCCESS) {
> - pr_efi_err("Failed to reallocate memory for files\n");
> + pr_efi_err("Failed to allocate memory for files\n");
> goto err_close_file;
> }
>
> --
> 2.25.0
>