2020-02-21 10:43:49

by Xu Wang

Subject: [PATCH] iwlegacy: Remove unneeded variable ret

Remove unneeded variable ret used to store return value.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 +---
drivers/net/wireless/intel/iwlegacy/4965.c | 3 +--
2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
index 206b43b9dff8..9167c3d2711d 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
@@ -228,9 +228,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf,
static int
il3945_remove_static_key(struct il_priv *il)
{
- int ret = -EOPNOTSUPP;
-
- return ret;
+ return -EOPNOTSUPP;
}

static int
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index 34d0579132ce..fc8fa5818de7 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -416,7 +416,6 @@ il4965_set_ucode_ptrs(struct il_priv *il)
{
dma_addr_t pinst;
dma_addr_t pdata;
- int ret = 0;

/* bits 35:4 for 4965 */
pinst = il->ucode_code.p_addr >> 4;
@@ -433,7 +432,7 @@ il4965_set_ucode_ptrs(struct il_priv *il)
il->ucode_code.len | BSM_DRAM_INST_LOAD);
D_INFO("Runtime uCode pointers are set.\n");

- return ret;
+ return 0;
}

/**
--
2.17.1

2020-02-22 13:24:42

by Stanislaw Gruszka

Subject: Re: [PATCH] iwlegacy: Remove unneeded variable ret

On Fri, Feb 21, 2020 at 06:43:03PM +0800, Xu Wang wrote:
> Remove unneeded variable ret used to store return value.
>
> Signed-off-by: Xu Wang <[email protected]>
Acked-by: Stanislaw Gruszka <[email protected]>