2020-02-23 13:16:07

by Ondřej Jirman

Subject: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led

The AXP813 PMIC can control one LED. Add binding to represent the LED.

Signed-off-by: Ondrej Jirman <[email protected]>
---
.../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml

diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
new file mode 100644
index 0000000000000..79282d55764bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LED driver for AXP813 PMIC from X-Powers.
+
+maintainers:
+ - Ondrej Jirman <[email protected]>
+
+description: |
+ This module is part of the AXP20x MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/axp20x.txt.
+
+ The LED controller is represented as a sub-node of the PMIC node on
+ the device tree.
+
+properties:
+ compatible:
+ const: x-powers,axp813-charger-led
+
+required:
+ - compatible
--
2.25.1

2020-02-25 13:12:12

by Dan Murphy

Subject: Re: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led

Ondrej

On 2/23/20 7:14 AM, Ondrej Jirman wrote:
> The AXP813 PMIC can control one LED. Add binding to represent the LED.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> new file mode 100644
> index 0000000000000..79282d55764bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for AXP813 PMIC from X-Powers.
> +
> +maintainers:
> + - Ondrej Jirman <[email protected]>
> +
> +description: |
> + This module is part of the AXP20x MFD device. For more details
> + see Documentation/devicetree/bindings/mfd/axp20x.txt.
> +
> + The LED controller is represented as a sub-node of the PMIC node on
> + the device tree.
> +
> +properties:
> + compatible:
> + const: x-powers,axp813-charger-led
> +
> +required:
> + - compatible

You need to add the color and function properties for proper LED device
name presentation per the bindings/leds/common.yaml binding.

Dan

2020-02-26 22:31:02

by Rob Herring (Arm)

Subject: Re: [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led

On Sun, Feb 23, 2020 at 02:14:32PM +0100, Ondrej Jirman wrote:
> The AXP813 PMIC can control one LED. Add binding to represent the LED.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/leds/leds-axp20x.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-axp20x.yaml b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> new file mode 100644
> index 0000000000000..79282d55764bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-axp20x.yaml
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-axp20x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for AXP813 PMIC from X-Powers.
> +
> +maintainers:
> + - Ondrej Jirman <[email protected]>
> +
> +description: |
> + This module is part of the AXP20x MFD device. For more details
> + see Documentation/devicetree/bindings/mfd/axp20x.txt.

Really, we should convert this first as this should either just be
referenced from the MFD schema or just directly put into it.

Rob