2020-02-23 13:15:27

by Ondřej Jirman

Subject: [PATCH 3/4] ARM: dts: axp813: Add charger LED

PMIC supports charging status indication via a LED. Add support
for it.

Signed-off-by: Ondrej Jirman <[email protected]>
---
arch/arm/boot/dts/axp81x.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
index 1dfeeceabf4c3..00b092f94433d 100644
--- a/arch/arm/boot/dts/axp81x.dtsi
+++ b/arch/arm/boot/dts/axp81x.dtsi
@@ -175,4 +175,9 @@ reg_drivevbus: drivevbus {
usb_power_supply: usb-power-supply {
compatible = "x-powers,axp813-usb-power-supply";
};
+
+ charger_led: charger-led {
+ compatible = "x-powers,axp813-charger-led";
+ status = "disabled";
+ };
};
--
2.25.1

2020-02-25 13:09:10

by Dan Murphy

Subject: Re: [PATCH 3/4] ARM: dts: axp813: Add charger LED

Ondrej

On 2/23/20 7:14 AM, Ondrej Jirman wrote:
> PMIC supports charging status indication via a LED. Add support
> for it.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> arch/arm/boot/dts/axp81x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 1dfeeceabf4c3..00b092f94433d 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -175,4 +175,9 @@ reg_drivevbus: drivevbus {
> usb_power_supply: usb-power-supply {
> compatible = "x-powers,axp813-usb-power-supply";
> };
> +
> + charger_led: charger-led {
> + compatible = "x-powers,axp813-charger-led";
> + status = "disabled";

As I commented before you need to add function and color to this node
and read it from the driver.  Or you can add them to the over ride for
the specific use case.

Another question is is this LED only used for charging or can it be
multi purpose?

Dan


> + };
> };