2020-02-24 08:36:08

by Luca Ceresoli

Subject: [PATCH] i3c: master: use 'dev' variable in dev_err

of_i3c_master_add_i2c_boardinfo() already has a handy 'dev' variable, use
it and simplify code.

Signed-off-by: Luca Ceresoli <[email protected]>
---
drivers/i3c/master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7f8f896fa0c3..b56207bbed2b 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
* DEFSLVS command.
*/
if (boardinfo->base.flags & I2C_CLIENT_TEN) {
- dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+ dev_err(dev, "I2C device with 10 bit address not supported.");
return -ENOTSUPP;
}

--
2.25.0

2020-02-26 09:07:28

by Boris Brezillon

Subject: Re: [PATCH] i3c: master: use 'dev' variable in dev_err

Hello Lucas,

On Mon, 24 Feb 2020 09:34:39 +0100
Luca Ceresoli <[email protected]> wrote:

> of_i3c_master_add_i2c_boardinfo() already has a handy 'dev' variable, use
> it and simplify code.

I already applied a similar patch from Wolfram, but thanks for your
contribution.

Regards,

Boris

>
> Signed-off-by: Luca Ceresoli <[email protected]>
> ---
> drivers/i3c/master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f8f896fa0c3..b56207bbed2b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(&master->dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.");
> return -ENOTSUPP;
> }
>