2020-02-23 17:30:00

by Ondřej Jirman

[permalink] [raw]
Subject: [PATCH 1/3] arm64: dts: sun50i-a64: Add i2c2 pins

PinePhone needs I2C2 pins description. Add it.

Signed-off-by: Ondrej Jirman <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 862b47dc9dc90..0fdf5f400d743 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -671,6 +671,11 @@ i2c1_pins: i2c1-pins {
function = "i2c1";
};

+ i2c2_pins: i2c2-pins {
+ pins = "PE14", "PE15";
+ function = "i2c2";
+ };
+
/omit-if-no-ref/
lcd_rgb666_pins: lcd-rgb666-pins {
pins = "PD0", "PD1", "PD2", "PD3", "PD4",
--
2.25.1


2020-02-24 11:01:26

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 1/3] arm64: dts: sun50i-a64: Add i2c2 pins

On Sun, Feb 23, 2020 at 06:29:14PM +0100, Ondrej Jirman wrote:
> PinePhone needs I2C2 pins description. Add it.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 862b47dc9dc90..0fdf5f400d743 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -671,6 +671,11 @@ i2c1_pins: i2c1-pins {
> function = "i2c1";
> };
>
> + i2c2_pins: i2c2-pins {
> + pins = "PE14", "PE15";
> + function = "i2c2";
> + };
> +

Setting it as the default muxing for i2c2 would be great

Maxime

Attachments:
(No filename) (800.00 B)
 signature.asc (235.00 B)
 Download all attachments

2020-02-24 13:00:37

by Ondřej Jirman

[permalink] [raw]
Subject: Re: [PATCH 1/3] arm64: dts: sun50i-a64: Add i2c2 pins

On Mon, Feb 24, 2020 at 12:01:00PM +0100, Maxime Ripard wrote:
> On Sun, Feb 23, 2020 at 06:29:14PM +0100, Ondrej Jirman wrote:
> > PinePhone needs I2C2 pins description. Add it.
> >
> > Signed-off-by: Ondrej Jirman <[email protected]>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index 862b47dc9dc90..0fdf5f400d743 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -671,6 +671,11 @@ i2c1_pins: i2c1-pins {
> > function = "i2c1";
> > };
> >
> > + i2c2_pins: i2c2-pins {
> > + pins = "PE14", "PE15";
> > + function = "i2c2";
> > + };
> > +
>
> Setting it as the default muxing for i2c2 would be great

Right, I checked the datasheet and it looks like this is the only pins where
i2c2 can be muxed to.

I will change it.

regards,
o.

> Maxime