2020-02-24 23:58:12

by Florian Fainelli

Subject: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec

We are still experiencing some packet loss with the existing advanced
congestion buffering (ACB) settings with the IMP port configured for
2Gb/sec, so revert to conservative link speeds that do not produce
packet loss until this is resolved.

Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/net/dsa/bcm_sf2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index d1955543acd1..b0f5280a83cb 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -69,8 +69,7 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)
/* Force link status for IMP port */
reg = core_readl(priv, offset);
reg |= (MII_SW_OR | LINK_STS);
- if (priv->type == BCM7278_DEVICE_ID)
- reg |= GMII_SPEED_UP_2G;
+ reg &= ~GMII_SPEED_UP_2G;
core_writel(priv, reg, offset);

/* Enable Broadcast, Multicast, Unicast forwarding to IMP port */
--
2.17.1

2020-02-25 15:25:50

by Vivien Didelot

Subject: Re: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec

On Mon, 24 Feb 2020 15:56:32 -0800, Florian Fainelli <[email protected]> wrote:
> We are still experiencing some packet loss with the existing advanced
> congestion buffering (ACB) settings with the IMP port configured for
> 2Gb/sec, so revert to conservative link speeds that do not produce
> packet loss until this is resolved.
>
> Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
> Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Vivien Didelot <[email protected]>

2020-02-27 00:40:37

by David Miller

Subject: Re: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec

From: Florian Fainelli <[email protected]>
Date: Mon, 24 Feb 2020 15:56:32 -0800

> We are still experiencing some packet loss with the existing advanced
> congestion buffering (ACB) settings with the IMP port configured for
> 2Gb/sec, so revert to conservative link speeds that do not produce
> packet loss until this is resolved.
>
> Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec")
> Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port")
> Signed-off-by: Florian Fainelli <[email protected]>

Applied and queued up for v5.5 -stable.

Thanks.