2020-02-25 12:10:06

by Tomer Tayar

Subject: [PATCH] habanalabs: Remove unused parse_cnt variable

The "parse_cnt" variable is incremented while validating the CS chunks,
but it is actually not being used.

Signed-off-by: Tomer Tayar <[email protected]>
---
drivers/misc/habanalabs/command_submission.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/habanalabs/command_submission.c b/drivers/misc/habanalabs/command_submission.c
index 73ef0f9d758a..409276b6374d 100644
--- a/drivers/misc/habanalabs/command_submission.c
+++ b/drivers/misc/habanalabs/command_submission.c
@@ -509,7 +509,7 @@ static int _hl_cs_ioctl(struct hl_fpriv *hpriv, void __user *chunks,
struct hl_cb *cb;
bool int_queues_only = true;
u32 size_to_copy;
- int rc, i, parse_cnt;
+ int rc, i;

*cs_seq = ULLONG_MAX;

@@ -549,7 +549,7 @@ static int _hl_cs_ioctl(struct hl_fpriv *hpriv, void __user *chunks,
hl_debugfs_add_cs(cs);

/* Validate ALL the CS chunks before submitting the CS */
- for (i = 0, parse_cnt = 0 ; i < num_chunks ; i++, parse_cnt++) {
+ for (i = 0 ; i < num_chunks ; i++) {
struct hl_cs_chunk *chunk = &cs_chunk_array[i];
enum hl_queue_type queue_type;
bool is_kernel_allocated_cb;
--
2.17.1

2020-02-25 12:13:02

by Oded Gabbay

Subject: Re: [PATCH] habanalabs: Remove unused parse_cnt variable

On Tue, Feb 25, 2020 at 1:24 PM Tomer Tayar <[email protected]> wrote:
>
> The "parse_cnt" variable is incremented while validating the CS chunks,
> but it is actually not being used.
>
> Signed-off-by: Tomer Tayar <[email protected]>
> ---
> drivers/misc/habanalabs/command_submission.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/command_submission.c b/drivers/misc/habanalabs/command_submission.c
> index 73ef0f9d758a..409276b6374d 100644
> --- a/drivers/misc/habanalabs/command_submission.c
> +++ b/drivers/misc/habanalabs/command_submission.c
> @@ -509,7 +509,7 @@ static int _hl_cs_ioctl(struct hl_fpriv *hpriv, void __user *chunks,
> struct hl_cb *cb;
> bool int_queues_only = true;
> u32 size_to_copy;
> - int rc, i, parse_cnt;
> + int rc, i;
>
> *cs_seq = ULLONG_MAX;
>
> @@ -549,7 +549,7 @@ static int _hl_cs_ioctl(struct hl_fpriv *hpriv, void __user *chunks,
> hl_debugfs_add_cs(cs);
>
> /* Validate ALL the CS chunks before submitting the CS */
> - for (i = 0, parse_cnt = 0 ; i < num_chunks ; i++, parse_cnt++) {
> + for (i = 0 ; i < num_chunks ; i++) {
> struct hl_cs_chunk *chunk = &cs_chunk_array[i];
> enum hl_queue_type queue_type;
> bool is_kernel_allocated_cb;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next
Thanks,
Oded