2020-02-20 05:53:23

by Saravana Kannan

Subject: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

Add support for creating device links out of more DT properties.

To: lkml <[email protected]>
To: John Stultz <[email protected]>
To: Rob Herring <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Todd Kjos <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Liam Girdwood <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Signed-off-by: Saravana Kannan <[email protected]>
---
drivers/of/property.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index e851c57a15b0..d977c11decda 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1204,6 +1204,8 @@ DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells")
DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells")
DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL)
DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells")
+DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells")
+DEFINE_SIMPLE_PROP(hwlocks, "hwlocks", "#hwlock-cells")
DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
DEFINE_SUFFIX_PROP(gpios, "-gpios", "#gpio-cells")
@@ -1226,6 +1228,8 @@ static const struct supplier_bindings of_supplier_bindings[] = {
{ .parse_prop = parse_io_channels, },
{ .parse_prop = parse_interrupt_parent, },
{ .parse_prop = parse_dmas, },
+ { .parse_prop = parse_power_domains, },
+ { .parse_prop = parse_hwlocks, },
{ .parse_prop = parse_regulators, },
{ .parse_prop = parse_gpio, },
{ .parse_prop = parse_gpios, },
--
2.25.0.265.gbab2e86ba0-goog

2020-02-20 23:27:53

by John Stultz

Subject: Re: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

On Wed, Feb 19, 2020 at 9:53 PM Saravana Kannan <[email protected]> wrote:
>
> Add support for creating device links out of more DT properties.
>
> To: lkml <[email protected]>
> To: John Stultz <[email protected]>
> To: Rob Herring <[email protected]>

Just as a heads up, git-send-email doesn't seem to pick up these To:
lines, so I had to dig this out of an archive.

> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Kevin Hilman <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: Todd Kjos <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Liam Girdwood <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: [email protected]
> Signed-off-by: Saravana Kannan <[email protected]>
> ---
> drivers/of/property.c | 4 ++++
> 1 file changed, 4 insertions(+)

This does seem to work for me, allowing various clk drivers to be used
as modules! This removes the functional need for my recent driver core
patch series around the deferred_probe_timeout (though the cleanup
bits in there may still be worth while).

Tested-by: John Stultz <[email protected]>

Thanks for sending it out!
-john

2020-02-20 23:32:06

by Saravana Kannan

Subject: Re: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

On Thu, Feb 20, 2020 at 3:26 PM John Stultz <[email protected]> wrote:
>
> On Wed, Feb 19, 2020 at 9:53 PM Saravana Kannan <[email protected]> wrote:
> >
> > Add support for creating device links out of more DT properties.
> >
> > To: lkml <[email protected]>
> > To: John Stultz <[email protected]>
> > To: Rob Herring <[email protected]>
>
> Just as a heads up, git-send-email doesn't seem to pick up these To:
> lines, so I had to dig this out of an archive.

Weird! Left out the main person who'd care about this patch.

>
> > Cc: "Rafael J. Wysocki" <[email protected]>
> > Cc: Kevin Hilman <[email protected]>
> > Cc: Ulf Hansson <[email protected]>
> > Cc: Pavel Machek <[email protected]>
> > Cc: Len Brown <[email protected]>
> > Cc: Todd Kjos <[email protected]>
> > Cc: Bjorn Andersson <[email protected]>
> > Cc: Liam Girdwood <[email protected]>
> > Cc: Mark Brown <[email protected]>
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Saravana Kannan <[email protected]>
> > ---
> > drivers/of/property.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> This does seem to work for me, allowing various clk drivers to be used
> as modules! This removes the functional need for my recent driver core
> patch series around the deferred_probe_timeout (though the cleanup
> bits in there may still be worth while).
>
> Tested-by: John Stultz <[email protected]>
>
> Thanks for sending it out!

Thanks for the Tested-by!

Rob,

Can you pick this up for the next rc?

-Saravana

2020-02-25 21:46:37

by Saravana Kannan

Subject: Re: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

On Thu, Feb 20, 2020 at 3:30 PM Saravana Kannan <[email protected]> wrote:
>
> On Thu, Feb 20, 2020 at 3:26 PM John Stultz <[email protected]> wrote:
> >
> > On Wed, Feb 19, 2020 at 9:53 PM Saravana Kannan <[email protected]> wrote:
> > >
> > > Add support for creating device links out of more DT properties.
> > >
> > > To: lkml <[email protected]>
> > > To: John Stultz <[email protected]>
> > > To: Rob Herring <[email protected]>
> >
> > Just as a heads up, git-send-email doesn't seem to pick up these To:
> > lines, so I had to dig this out of an archive.
>
> Weird! Left out the main person who'd care about this patch.
>
> >
> > > Cc: "Rafael J. Wysocki" <[email protected]>
> > > Cc: Kevin Hilman <[email protected]>
> > > Cc: Ulf Hansson <[email protected]>
> > > Cc: Pavel Machek <[email protected]>
> > > Cc: Len Brown <[email protected]>
> > > Cc: Todd Kjos <[email protected]>
> > > Cc: Bjorn Andersson <[email protected]>
> > > Cc: Liam Girdwood <[email protected]>
> > > Cc: Mark Brown <[email protected]>
> > > Cc: Greg Kroah-Hartman <[email protected]>
> > > Cc: [email protected]
> > > Signed-off-by: Saravana Kannan <[email protected]>
> > > ---
> > > drivers/of/property.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> >
> > This does seem to work for me, allowing various clk drivers to be used
> > as modules! This removes the functional need for my recent driver core
> > patch series around the deferred_probe_timeout (though the cleanup
> > bits in there may still be worth while).
> >
> > Tested-by: John Stultz <[email protected]>
> >
> > Thanks for sending it out!
>
> Thanks for the Tested-by!
>
> Rob,
>
> Can you pick this up for the next rc?

Friendly reminder.

-Saravana

2020-02-26 15:19:17

by Rob Herring

Subject: Re: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

On Tue, Feb 25, 2020 at 3:46 PM Saravana Kannan <[email protected]> wrote:
>
> On Thu, Feb 20, 2020 at 3:30 PM Saravana Kannan <[email protected]> wrote:
> >
> > On Thu, Feb 20, 2020 at 3:26 PM John Stultz <[email protected]> wrote:
> > >
> > > On Wed, Feb 19, 2020 at 9:53 PM Saravana Kannan <[email protected]> wrote:
> > > >
> > > > Add support for creating device links out of more DT properties.
> > > >
> > > > To: lkml <[email protected]>
> > > > To: John Stultz <[email protected]>
> > > > To: Rob Herring <[email protected]>
> > >
> > > Just as a heads up, git-send-email doesn't seem to pick up these To:
> > > lines, so I had to dig this out of an archive.
> >
> > Weird! Left out the main person who'd care about this patch.
> >
> > >
> > > > Cc: "Rafael J. Wysocki" <[email protected]>
> > > > Cc: Kevin Hilman <[email protected]>
> > > > Cc: Ulf Hansson <[email protected]>
> > > > Cc: Pavel Machek <[email protected]>
> > > > Cc: Len Brown <[email protected]>
> > > > Cc: Todd Kjos <[email protected]>
> > > > Cc: Bjorn Andersson <[email protected]>
> > > > Cc: Liam Girdwood <[email protected]>
> > > > Cc: Mark Brown <[email protected]>
> > > > Cc: Greg Kroah-Hartman <[email protected]>
> > > > Cc: [email protected]
> > > > Signed-off-by: Saravana Kannan <[email protected]>
> > > > ---
> > > > drivers/of/property.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > >
> > > This does seem to work for me, allowing various clk drivers to be used
> > > as modules! This removes the functional need for my recent driver core
> > > patch series around the deferred_probe_timeout (though the cleanup
> > > bits in there may still be worth while).
> > >
> > > Tested-by: John Stultz <[email protected]>
> > >
> > > Thanks for sending it out!
> >
> > Thanks for the Tested-by!
> >
> > Rob,
> >
> > Can you pick this up for the next rc?

You mean 5.7-rc1, right?

> Friendly reminder.

No need to ping. You can check patchwork[1] to see where you are in the queue.

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

2020-02-26 15:51:47

by Rob Herring (Arm)

Subject: Re: [PATCH v1] of: property: Add device link support for power-domains and hwlocks

On Wed, 19 Feb 2020 21:52:50 -0800, Saravana Kannan wrote:
> Add support for creating device links out of more DT properties.
>
> To: lkml <[email protected]>
> To: John Stultz <[email protected]>
> To: Rob Herring <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Kevin Hilman <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: Todd Kjos <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Liam Girdwood <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: [email protected]
> Signed-off-by: Saravana Kannan <[email protected]>
> ---
> drivers/of/property.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Applied, thanks.

Rob