2020-02-27 09:00:51

by Tan, Ley Foon

Subject: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible

Fix gmac compatible string to "altr,socfpga-stmmac-a10-s10". Gmac for
Agilex should use same compatible as Stratix 10.

Signed-off-by: Ley Foon Tan <[email protected]>
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index e1d357eaad7c..d8c44d3ca15a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -102,7 +102,7 @@
};

gmac0: ethernet@ff800000 {
- compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+ compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
reg = <0xff800000 0x2000>;
interrupts = <0 90 4>;
interrupt-names = "macirq";
@@ -118,7 +118,7 @@
};

gmac1: ethernet@ff802000 {
- compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+ compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
reg = <0xff802000 0x2000>;
interrupts = <0 91 4>;
interrupt-names = "macirq";
@@ -134,7 +134,7 @@
};

gmac2: ethernet@ff804000 {
- compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+ compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
reg = <0xff804000 0x2000>;
interrupts = <0 92 4>;
interrupt-names = "macirq";
--
2.19.0

2020-02-27 14:49:42

by Dinh Nguyen

Subject: Re: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible

Hi Ley Foon,

Thanks for catching this. Can you resend with the Fixes tag and cc the
stable mailing list to get this backported to the stable kernels.

Thanks,
Dinh

On 2/26/20 12:35 PM, Ley Foon Tan wrote:
> Fix gmac compatible string to "altr,socfpga-stmmac-a10-s10". Gmac for
> Agilex should use same compatible as Stratix 10.
>
> Signed-off-by: Ley Foon Tan <[email protected]>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index e1d357eaad7c..d8c44d3ca15a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -102,7 +102,7 @@
> };
>
> gmac0: ethernet@ff800000 {
> - compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> + compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
> reg = <0xff800000 0x2000>;
> interrupts = <0 90 4>;
> interrupt-names = "macirq";
> @@ -118,7 +118,7 @@
> };
>
> gmac1: ethernet@ff802000 {
> - compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> + compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
> reg = <0xff802000 0x2000>;
> interrupts = <0 91 4>;
> interrupt-names = "macirq";
> @@ -134,7 +134,7 @@
> };
>
> gmac2: ethernet@ff804000 {
> - compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> + compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
> reg = <0xff804000 0x2000>;
> interrupts = <0 92 4>;
> interrupt-names = "macirq";
>

2020-02-28 00:41:35

by Tan, Ley Foon

Subject: RE: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible

> -----Original Message-----
> From: Dinh Nguyen <[email protected]>
> Sent: Thursday, February 27, 2020 10:49 PM
> To: Tan, Ley Foon <[email protected]>
> Cc: [email protected]; See, Chin Liang
> <[email protected]>; [email protected]
> Subject: Re: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
>
> Hi Ley Foon,
>
> Thanks for catching this. Can you resend with the Fixes tag and cc the stable
> mailing list to get this backported to the stable kernels.
>
> Thanks,
> Dinh

Okay.