2020-02-28 04:02:24

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path

drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
#include <../gpio/gpiolib.h>
^~~~~~~~~~~~~~~~~~~

Fix this wrong include path.

Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/pinctrl/pinctrl-da9062.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index f704ee0b2fd9..c15eb6e99bc1 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -25,7 +25,7 @@
* We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
* the gpio is active low without a vendor specific dt-binding.
*/
-#include <../gpio/gpiolib.h>
+#include "../../gpio/gpiolib.h"

#define DA9062_TYPE(offset) (4 * (offset % 2))
#define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
--
2.17.1



2020-02-28 06:31:37

by Yue Haibing

[permalink] [raw]
Subject: Re: [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path

Sorry, pls ignore this, will resend v2.

On 2020/2/28 12:00, YueHaibing wrote:
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.
>
> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/pinctrl/pinctrl-da9062.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..c15eb6e99bc1 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include "../../gpio/gpiolib.h"
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
>

2020-02-28 06:35:53

by Yue Haibing

[permalink] [raw]
Subject: [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path

gcc 7.4.0 build fails:

drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
#include <../gpio/gpiolib.h>
^~~~~~~~~~~~~~~~~~~

Fix this wrong include path.

Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
Signed-off-by: YueHaibing <[email protected]>
---
v2: Fix wrong path
---
drivers/pinctrl/pinctrl-da9062.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index f704ee0b2fd9..c15eb6e99bc1 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -25,7 +25,7 @@
* We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
* the gpio is active low without a vendor specific dt-binding.
*/
-#include <../gpio/gpiolib.h>
+#include "../gpio/gpiolib.h"

#define DA9062_TYPE(offset) (4 * (offset % 2))
#define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
--
2.17.1


2020-02-28 07:00:36

by Marco Felsch

[permalink] [raw]
Subject: Re: [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path

Hi YueHaibing,

thanks for covering that and sorry for that bug. Didn't covered that
because I'm using a newer toolchain.

On 20-02-28 14:34, YueHaibing wrote:
> gcc 7.4.0 build fails:
>
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.

nit, the path isn't wrong. Whats wrong is the syntax.

Reviewed-by: Marco Felsch <[email protected]>

> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> v2: Fix wrong path
> ---
> drivers/pinctrl/pinctrl-da9062.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..c15eb6e99bc1 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include "../gpio/gpiolib.h"
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
> --
> 2.17.1
>
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2020-02-28 13:17:26

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path

On Fri, Feb 28, 2020 at 7:35 AM YueHaibing <[email protected]> wrote:

> gcc 7.4.0 build fails:
>
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.
>
> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> v2: Fix wrong path

Good catch!

Patch applied with Marco's ACK.

Yours,
Linus Walleij