2020-03-01 23:06:38

by Arvind Sankar

[permalink] [raw]
Subject: [PATCH 0/5] efi/x86 cleanups and one bugfix

First 3 patches are misc. beautifications to the new compat PE entry
code.

Next patch stops EFI stub using code32_start field to communicate the
address of startup_32, instead returning it directly to efi_stub_entry.

Last patch is a bugfix for x86/boot/head code to use unsigned
comparisons on addresses rather than signed.

Based on tip:efi/core

Arvind Sankar (5):
efi/x86: Annotate the LOADED_IMAGE_PROTOCOL_GUID with SYM_DATA
efi/x86: Respect 32-bit ABI in efi32_pe_entry
efi/x86: Make efi32_pe_entry more readable
efi/x86: Avoid using code32_start
x86/boot: Use unsigned comparison for addresses

arch/x86/boot/compressed/head_32.S | 5 +-
arch/x86/boot/compressed/head_64.S | 70 ++++++++++++++++++-------
arch/x86/kernel/asm-offsets.c | 1 -
drivers/firmware/efi/libstub/x86-stub.c | 10 ++--
4 files changed, 57 insertions(+), 29 deletions(-)

--
2.24.1


2020-03-02 07:50:53

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: [PATCH 0/5] efi/x86 cleanups and one bugfix

On Mon, 2 Mar 2020 at 00:04, Arvind Sankar <[email protected]> wrote:
>
> First 3 patches are misc. beautifications to the new compat PE entry
> code.
>
> Next patch stops EFI stub using code32_start field to communicate the
> address of startup_32, instead returning it directly to efi_stub_entry.
>
> Last patch is a bugfix for x86/boot/head code to use unsigned
> comparisons on addresses rather than signed.
>
> Based on tip:efi/core
>
> Arvind Sankar (5):
> efi/x86: Annotate the LOADED_IMAGE_PROTOCOL_GUID with SYM_DATA
> efi/x86: Respect 32-bit ABI in efi32_pe_entry
> efi/x86: Make efi32_pe_entry more readable
> efi/x86: Avoid using code32_start
> x86/boot: Use unsigned comparison for addresses
>

Thanks Arvind. This looks really good, as usual. I had one question,
the rest looks good to go.