2020-03-02 11:58:46

by Johan Jonker

Subject: [PATCH 1/2] dt-bindings: usb: dwc2: add compatible property for rk3328 usb

A test with the command below gives these errors:

arch/arm64/boot/dts/rockchip/rk3328-a1.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3328-rock64.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas

The compatible property for rk3328 dwc2 usb was somehow never added to
the documention. Fix this error by adding
'rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2'
to dwc2.yaml.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/dwc2.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index e95ba9373..e9f4cea21 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -41,6 +41,10 @@ properties:
- const: rockchip,rk3288-usb
- const: rockchip,rk3066-usb
- const: snps,dwc2
+ - items:
+ - const: rockchip,rk3328-usb
+ - const: rockchip,rk3066-usb
+ - const: snps,dwc2
- const: lantiq,arx100-usb
- const: lantiq,xrx200-usb
- items:
--
2.11.0

2020-03-02 11:59:47

by Johan Jonker

Subject: [PATCH 2/2] dt-bindings: usb: dwc2: add compatible property for rk3368 usb

A test with the command below gives these errors:

arch/arm64/boot/dts/rockchip/rk3368-evb-act8846.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3368-geekbox.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3368-lion-haikou.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas
arch/arm64/boot/dts/rockchip/rk3368-r88.dt.yaml: usb@ff580000: compatible:
['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
is not valid under any of the given schemas

The compatible property for rk3368 dwc2 usb was somehow never added to
the documention. Fix this error by adding
'rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'
to dwc2.yaml.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/dwc2.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index e9f4cea21..14aeb67e8 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -45,6 +45,10 @@ properties:
- const: rockchip,rk3328-usb
- const: rockchip,rk3066-usb
- const: snps,dwc2
+ - items:
+ - const: rockchip,rk3368-usb
+ - const: rockchip,rk3066-usb
+ - const: snps,dwc2
- const: lantiq,arx100-usb
- const: lantiq,xrx200-usb
- items:
--
2.11.0

2020-03-10 19:31:13

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc2: add compatible property for rk3328 usb

On Mon, Mar 02, 2020 at 12:58:11PM +0100, Johan Jonker wrote:
> A test with the command below gives these errors:
>
> arch/arm64/boot/dts/rockchip/rk3328-a1.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
>
> The compatible property for rk3328 dwc2 usb was somehow never added to
> the documention. Fix this error by adding
> 'rockchip,rk3328-usb', 'rockchip,rk3066-usb', 'snps,dwc2'
> to dwc2.yaml.
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/dwc2.yaml
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index e95ba9373..e9f4cea21 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -41,6 +41,10 @@ properties:
> - const: rockchip,rk3288-usb

Convert this entry to an 'enum' and add 'rockchip,rk3328-usb' here.

> - const: rockchip,rk3066-usb
> - const: snps,dwc2
> + - items:
> + - const: rockchip,rk3328-usb
> + - const: rockchip,rk3066-usb
> + - const: snps,dwc2
> - const: lantiq,arx100-usb
> - const: lantiq,xrx200-usb
> - items:
> --
> 2.11.0
>

2020-03-10 19:32:02

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] dt-bindings: usb: dwc2: add compatible property for rk3368 usb

On Mon, Mar 02, 2020 at 12:58:12PM +0100, Johan Jonker wrote:
> A test with the command below gives these errors:
>
> arch/arm64/boot/dts/rockchip/rk3368-evb-act8846.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3368-geekbox.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3368-lion-haikou.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
> arch/arm64/boot/dts/rockchip/rk3368-r88.dt.yaml: usb@ff580000: compatible:
> ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2']
> is not valid under any of the given schemas
>
> The compatible property for rk3368 dwc2 usb was somehow never added to
> the documention. Fix this error by adding
> 'rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'
> to dwc2.yaml.
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/dwc2.yaml
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index e9f4cea21..14aeb67e8 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -45,6 +45,10 @@ properties:
> - const: rockchip,rk3328-usb
> - const: rockchip,rk3066-usb
> - const: snps,dwc2
> + - items:
> + - const: rockchip,rk3368-usb

And you can do the same thing with this.

> + - const: rockchip,rk3066-usb
> + - const: snps,dwc2
> - const: lantiq,arx100-usb
> - const: lantiq,xrx200-usb
> - items:
> --
> 2.11.0
>