2020-03-02 10:52:27

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/2] pty: define and set show_fdinfo only if procfs is enabled

On Mon, Mar 02, 2020 at 11:49:53AM +0100, Tobias Klauser wrote:
> Follow the pattern used with other *_show_fdinfo functions and only
> define and use pty_show_fdinfo if CONFIG_PROC_FS is set.

if proc_fs is not set, it will not be used anyway, right?

I'd rather keep #ifdef out of the .c files than add this. How much
memory does it save, and are you using a system without procfs that
needs this savings?

thanks,

greg k-h

2020-03-02 13:38:22

by Tobias Klauser

Subject: Re: [PATCH 1/2] pty: define and set show_fdinfo only if procfs is enabled

On 2020-03-02 at 11:51:53 +0100, Greg Kroah-Hartman <[email protected]> wrote:
> On Mon, Mar 02, 2020 at 11:49:53AM +0100, Tobias Klauser wrote:
> > Follow the pattern used with other *_show_fdinfo functions and only
> > define and use pty_show_fdinfo if CONFIG_PROC_FS is set.
>
> if proc_fs is not set, it will not be used anyway, right?

Right, it should never get called.

> I'd rather keep #ifdef out of the .c files than add this. How much
> memory does it save, and are you using a system without procfs that
> needs this savings?

The savings are marginal, so no I don't strictly need this. I just
figured all other *_show_fdinfo functions in the tree are #ifdef'ed in
the same way and it would be nice to be consistent.

Thanks