Missing ';' in the end of secure-monitor example node.
Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
Reported-by: Rob Herring <[email protected]>
Signed-off-by: Jianxin Pan <[email protected]>
---
Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index af32209..bc4e037 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -36,5 +36,5 @@ examples:
compatible = "amlogic,meson-a1-pwrc";
#power-domain-cells = <1>;
};
- }
+ };
--
2.7.4
Hi Jianxin,
Jianxin Pan <[email protected]> writes:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Jianxin Pan <[email protected]>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index af32209..bc4e037 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -36,5 +36,5 @@ examples:
> compatible = "amlogic,meson-a1-pwrc";
> #power-domain-cells = <1>;
> };
> - }
> + };
Thanks for the fix. Queued for v5.7.
@Arnd, @Olof: you can ignore this one. I requested Jianxin to send to
you thinking this was a fix for something you already queued, but it's
not. I'll handle it.
Kevin
On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring <[email protected]>
> Signed-off-by: Jianxin Pan <[email protected]>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Rob Herring <[email protected]> writes:
> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> Reported-by: Rob Herring <[email protected]>
>> Signed-off-by: Jianxin Pan <[email protected]>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
I've (re)added these tags:
Reviewed-by: Neil Armstrong <[email protected]>
Acked-by: Rob Herring <[email protected]>
when applying this time.
Jianxin, please collect the tags in the future and add when you send
follow-up versions.
Thanks,
Kevin
Hi Rob,
On 2020/3/3 4:15, Rob Herring wrote:
> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> Reported-by: Rob Herring <[email protected]>
>> Signed-off-by: Jianxin Pan <[email protected]>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
Sorry to forget the tag, Kevin has added it for me, and I will keep it in mind next time.
> If a tag was not added on purpose, please state why and what changed.
>
> .
>
On 2020/3/3 16:43, Kevin Hilman wrote:
> Rob Herring <[email protected]> writes:
>
>> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>>> Missing ';' in the end of secure-monitor example node.
>>>
>>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>>> Reported-by: Rob Herring <[email protected]>
>>> Signed-off-by: Jianxin Pan <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
>
> I've (re)added these tags:
>
> Reviewed-by: Neil Armstrong <[email protected]>
> Acked-by: Rob Herring <[email protected]>
>
> when applying this time.
>
> Jianxin, please collect the tags in the future and add when you send
> follow-up versions.
OK, I will do it next time, thanks for your time.
>
> Thanks,
>
> Kevin
>
> .
>
Rob Herring <[email protected]> writes:
> On Mon, Mar 2, 2020 at 10:31 AM Kevin Hilman <[email protected]> wrote:
>>
>> Hi Jianxin,
>>
>> Jianxin Pan <[email protected]> writes:
>>
>> > Missing ';' in the end of secure-monitor example node.
>> >
>> > Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> > Reported-by: Rob Herring <[email protected]>
>> > Signed-off-by: Jianxin Pan <[email protected]>
>> > ---
>> > Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > index af32209..bc4e037 100644
>> > --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > @@ -36,5 +36,5 @@ examples:
>> > compatible = "amlogic,meson-a1-pwrc";
>> > #power-domain-cells = <1>;
>> > };
>> > - }
>> > + };
>>
>> Thanks for the fix. Queued for v5.7.
>>
>> @Arnd, @Olof: you can ignore this one. I requested Jianxin to send to
>> you thinking this was a fix for something you already queued, but it's
>> not. I'll handle it.
>
> Someone has what needs fixing queued in linux-next, but this fix is
> still not there. Somehow it seems like features show up in linux-next
> faster than fixes for SoC tree...
The fix (this patch) is queued in my 'for-next' branch which I pushed
yesterday. I guess it missed next-20200310 but should be in tomorrow.
Kevin
[1] https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/log/?h=for-next