2020-03-03 04:05:57

by Andy Tang

[permalink] [raw]
Subject: [PATCH] thermal: qoriq: fix a compiling issue

From: Yuantian Tang <[email protected]>

Qoriq thermal driver is used by both PowerPC and ARM architecture.
When built for PowerPC architecture, it reports error:
undefined reference to `.__devm_regmap_init_mmio_clk'
To fix it, select config REGMAP_MMIO.

Signed-off-by: Yuantian Tang <[email protected]>
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 5a05db5438d6..5a0df0e54ce3 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -265,6 +265,7 @@ config QORIQ_THERMAL
tristate "QorIQ Thermal Monitoring Unit"
depends on THERMAL_OF
depends on HAS_IOMEM
+ select REGMAP_MMIO
help
Support for Thermal Monitoring Unit (TMU) found on QorIQ platforms.
It supports one critical trip point and one passive trip point. The
--
2.17.1


2020-03-03 07:52:36

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] thermal: qoriq: fix a compiling issue

On 03/03/2020 05:02, [email protected] wrote:
> From: Yuantian Tang <[email protected]>
>
> Qoriq thermal driver is used by both PowerPC and ARM architecture.
> When built for PowerPC architecture, it reports error:
> undefined reference to `.__devm_regmap_init_mmio_clk'
> To fix it, select config REGMAP_MMIO.
>
> Signed-off-by: Yuantian Tang <[email protected]>

Please add the 'Fixes' tag

Thanks

> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 5a05db5438d6..5a0df0e54ce3 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -265,6 +265,7 @@ config QORIQ_THERMAL
> tristate "QorIQ Thermal Monitoring Unit"
> depends on THERMAL_OF
> depends on HAS_IOMEM
> + select REGMAP_MMIO
> help
> Support for Thermal Monitoring Unit (TMU) found on QorIQ platforms.
> It supports one critical trip point and one passive trip point. The
> --
> 2.17.1
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog