2020-02-23 19:26:00

by Andrea Arcangeli

[permalink] [raw]
Subject: [PATCH 2/3] arm64: select CPUMASK_OFFSTACK if NUMA

It's unclear why normally CPUMASK_OFFSTACK can only be manually
configured "if DEBUG_PER_CPU_MAPS" which is not an option meant to be
enabled on enterprise arm64 kernels.

The default enterprise kernels NR_CPUS is 4096 which is fairly large.
So it'll save some RAM and it'll increase reliability to select
CPUMASK_OFFSET at least when NUMA is selected and a large NR_CPUS is
to be expected.

Signed-off-by: Andrea Arcangeli <[email protected]>
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 0b30e884e088..882887e65394 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -955,6 +955,7 @@ config NUMA
bool "Numa Memory Allocation and Scheduler Support"
select ACPI_NUMA if ACPI
select OF_NUMA
+ select CPUMASK_OFFSTACK
help
Enable NUMA (Non Uniform Memory Access) support.



2020-03-03 04:33:00

by Rafael Aquini

[permalink] [raw]
Subject: Re: [PATCH 2/3] arm64: select CPUMASK_OFFSTACK if NUMA

On Sun, Feb 23, 2020 at 02:25:19PM -0500, Andrea Arcangeli wrote:
> It's unclear why normally CPUMASK_OFFSTACK can only be manually
> configured "if DEBUG_PER_CPU_MAPS" which is not an option meant to be
> enabled on enterprise arm64 kernels.
>
> The default enterprise kernels NR_CPUS is 4096 which is fairly large.
> So it'll save some RAM and it'll increase reliability to select
> CPUMASK_OFFSET at least when NUMA is selected and a large NR_CPUS is
> to be expected.
>
> Signed-off-by: Andrea Arcangeli <[email protected]>
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 0b30e884e088..882887e65394 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -955,6 +955,7 @@ config NUMA
> bool "Numa Memory Allocation and Scheduler Support"
> select ACPI_NUMA if ACPI
> select OF_NUMA
> + select CPUMASK_OFFSTACK
> help
> Enable NUMA (Non Uniform Memory Access) support.
>

Acked-by: Rafael Aquini <[email protected]>