2020-03-05 18:24:56

by Mathias Kresin

Subject: [PATCH] pinctrl: falcon: fix syntax error

Add the missing semicolon after of_node_put to get the file compiled.

Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before return")
Cc: [email protected] # v5.4+
Signed-off-by: Mathias Kresin <[email protected]>
---
drivers/pinctrl/pinctrl-falcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c
index a454f57c264e..62c02b969327 100644
--- a/drivers/pinctrl/pinctrl-falcon.c
+++ b/drivers/pinctrl/pinctrl-falcon.c
@@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct platform_device *pdev)
falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
if (IS_ERR(falcon_info.clk[*bank])) {
dev_err(&ppdev->dev, "failed to get clock\n");
- of_node_put(np)
+ of_node_put(np);
return PTR_ERR(falcon_info.clk[*bank]);
}
falcon_info.membase[*bank] = devm_ioremap_resource(&pdev->dev,
--
2.17.1

2020-03-05 19:12:30

by Langer, Thomas

Subject: RE: [PATCH] pinctrl: falcon: fix syntax error

> -----Original Message-----
> From: [email protected] <linux-gpio-
> [email protected]> On Behalf Of Mathias Kresin
> Sent: Donnerstag, 5. März 2020 19:23
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]
> Subject: [PATCH] pinctrl: falcon: fix syntax error
>
> Add the missing semicolon after of_node_put to get the file compiled.
>
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before
> return")
> Cc: [email protected] # v5.4+
> Signed-off-by: Mathias Kresin <[email protected]>

Acked-by: Thomas Langer <[email protected]>

> ---
> drivers/pinctrl/pinctrl-falcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-falcon.c
> b/drivers/pinctrl/pinctrl-falcon.c
> index a454f57c264e..62c02b969327 100644
> --- a/drivers/pinctrl/pinctrl-falcon.c
> +++ b/drivers/pinctrl/pinctrl-falcon.c
> @@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct
> platform_device *pdev)
> falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
> if (IS_ERR(falcon_info.clk[*bank])) {
> dev_err(&ppdev->dev, "failed to get clock\n");
> - of_node_put(np)
> + of_node_put(np);
> return PTR_ERR(falcon_info.clk[*bank]);
> }
> falcon_info.membase[*bank] = devm_ioremap_resource(&pdev-
> >dev,
> --
> 2.17.1

2020-03-09 09:30:51

by Linus Walleij

Subject: Re: [PATCH] pinctrl: falcon: fix syntax error

On Thu, Mar 5, 2020 at 7:22 PM Mathias Kresin <[email protected]> wrote:

> Add the missing semicolon after of_node_put to get the file compiled.
>
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before return")
> Cc: [email protected] # v5.4+
> Signed-off-by: Mathias Kresin <[email protected]>

Patch applied for fixes with Thomas Ack.

Yours,
Linus Walleij