2020-03-04 14:55:38

by Vincenzo Frascino

Subject: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
CONFIG_PM is enabled. Having it disabled triggers the following warning
at compile time:

linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
static int komeda_rt_pm_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~
linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
static int komeda_rt_pm_suspend(struct device *dev)

Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
CONFIG_PM to address the issue.

Cc: "James (Qian) Wang" <[email protected]>
Cc: Liviu Dudau <[email protected]>
Cc: Mihail Atanassov <[email protected]>
Cc: Brian Starkey <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Signed-off-by: Vincenzo Frascino <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index ea5cd1e17304..dd3ae3d88687 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {

MODULE_DEVICE_TABLE(of, komeda_of_match);

+#ifdef CONFIG_PM
static int komeda_rt_pm_suspend(struct device *dev)
{
struct komeda_drv *mdrv = dev_get_drvdata(dev);
@@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)

return komeda_dev_resume(mdrv->mdev);
}
+#endif /* CONFIG_PM */

static int __maybe_unused komeda_pm_suspend(struct device *dev)
{
--
2.25.1

2020-03-05 18:44:12

by Liviu Dudau

Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
> CONFIG_PM is enabled. Having it disabled triggers the following warning
> at compile time:
>
> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
> static int komeda_rt_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
> static int komeda_rt_pm_suspend(struct device *dev)
>
> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
> CONFIG_PM to address the issue.
>
> Cc: "James (Qian) Wang" <[email protected]>
> Cc: Liviu Dudau <[email protected]>
> Cc: Mihail Atanassov <[email protected]>
> Cc: Brian Starkey <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Signed-off-by: Vincenzo Frascino <[email protected]>

Acked-by: Liviu Dudau <[email protected]>

Thanks for the patch, I will push it into drm-misc-fixes tomorrow.

Best regards,
Liviu

> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index ea5cd1e17304..dd3ae3d88687 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, komeda_of_match);
>
> +#ifdef CONFIG_PM
> static int komeda_rt_pm_suspend(struct device *dev)
> {
> struct komeda_drv *mdrv = dev_get_drvdata(dev);
> @@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)
>
> return komeda_dev_resume(mdrv->mdev);
> }
> +#endif /* CONFIG_PM */
>
> static int __maybe_unused komeda_pm_suspend(struct device *dev)
> {
> --
> 2.25.1
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

2020-03-06 04:16:35

by James Qian Wang

Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

On Fri, Mar 06, 2020 at 02:42:55AM +0800, Liviu Dudau wrote:
> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
> > komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
> > CONFIG_PM is enabled. Having it disabled triggers the following warning
> > at compile time:
> >
> > linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
> > warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
> > static int komeda_rt_pm_resume(struct device *dev)
> > ^~~~~~~~~~~~~~~~~~~
> > linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
> > warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
> > static int komeda_rt_pm_suspend(struct device *dev)
> >
> > Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
> > CONFIG_PM to address the issue.
> >
> > Cc: "James (Qian) Wang" <[email protected]>
> > Cc: Liviu Dudau <[email protected]>
> > Cc: Mihail Atanassov <[email protected]>
> > Cc: Brian Starkey <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Signed-off-by: Vincenzo Frascino <[email protected]>
>

Hi Vincenzo:

Thanks for the patch.

and Vincenzo & Liviu, sorry

Since there is a patch for this problem already:
https://patchwork.freedesktop.org/series/71721/

And I have pushed that old fix to drm-misc-fixes just before I saw
this mail. sorry.

> Acked-by: Liviu Dudau <[email protected]>
>
> Thanks for the patch, I will push it into drm-misc-fixes tomorrow.
>
> Best regards,
> Liviu
>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> > index ea5cd1e17304..dd3ae3d88687 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> > @@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {
> >
> > MODULE_DEVICE_TABLE(of, komeda_of_match);
> >
> > +#ifdef CONFIG_PM
> > static int komeda_rt_pm_suspend(struct device *dev)
> > {
> > struct komeda_drv *mdrv = dev_get_drvdata(dev);
> > @@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)
> >
> > return komeda_dev_resume(mdrv->mdev);
> > }
> > +#endif /* CONFIG_PM */
> >
> > static int __maybe_unused komeda_pm_suspend(struct device *dev)
> > {
> > --
> > 2.25.1
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯

2020-03-06 09:52:13

by Vincenzo Frascino

Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

Hi James,

On 3/6/20 4:14 AM, james qian wang (Arm Technology China) wrote:
> On Fri, Mar 06, 2020 at 02:42:55AM +0800, Liviu Dudau wrote:
>> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
>>> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
>>> CONFIG_PM is enabled. Having it disabled triggers the following warning
>>> at compile time:
>>>
>>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
>>> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
>>> static int komeda_rt_pm_resume(struct device *dev)
>>> ^~~~~~~~~~~~~~~~~~~
>>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
>>> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
>>> static int komeda_rt_pm_suspend(struct device *dev)
>>>
>>> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
>>> CONFIG_PM to address the issue.
>>>
>>> Cc: "James (Qian) Wang" <[email protected]>
>>> Cc: Liviu Dudau <[email protected]>
>>> Cc: Mihail Atanassov <[email protected]>
>>> Cc: Brian Starkey <[email protected]>
>>> Cc: David Airlie <[email protected]>
>>> Cc: Daniel Vetter <[email protected]>
>>> Signed-off-by: Vincenzo Frascino <[email protected]>
>>
>
> Hi Vincenzo:
>
> Thanks for the patch.
>
> and Vincenzo & Liviu, sorry
>
> Since there is a patch for this problem already:
> https://patchwork.freedesktop.org/series/71721/
>
> And I have pushed that old fix to drm-misc-fixes just before I saw
> this mail. sorry.
>

No issue, as far as it is fixed :) It is annoying stepping on it during
randconfig :)

Thanks for letting me know!

[...]

--
Regards,
Vincenzo

2020-03-06 09:53:37

by Vincenzo Frascino

Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

Hi Liviu,

On 3/5/20 6:42 PM, Liviu Dudau wrote:
> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
>> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
>> CONFIG_PM is enabled. Having it disabled triggers the following warning
>> at compile time:
>>
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
>> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
>> static int komeda_rt_pm_resume(struct device *dev)
>> ^~~~~~~~~~~~~~~~~~~
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
>> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
>> static int komeda_rt_pm_suspend(struct device *dev)
>>
>> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
>> CONFIG_PM to address the issue.
>>
>> Cc: "James (Qian) Wang" <[email protected]>
>> Cc: Liviu Dudau <[email protected]>
>> Cc: Mihail Atanassov <[email protected]>
>> Cc: Brian Starkey <[email protected]>
>> Cc: David Airlie <[email protected]>
>> Cc: Daniel Vetter <[email protected]>
>> Signed-off-by: Vincenzo Frascino <[email protected]>
>
> Acked-by: Liviu Dudau <[email protected]>
>
> Thanks for the patch, I will push it into drm-misc-fixes tomorrow.
>

Thank you!

> Best regards,
> Liviu
>
>> ---
>> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> index ea5cd1e17304..dd3ae3d88687 100644
>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> @@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {
>>
>> MODULE_DEVICE_TABLE(of, komeda_of_match);
>>
>> +#ifdef CONFIG_PM
>> static int komeda_rt_pm_suspend(struct device *dev)
>> {
>> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>> @@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)
>>
>> return komeda_dev_resume(mdrv->mdev);
>> }
>> +#endif /* CONFIG_PM */
>>
>> static int __maybe_unused komeda_pm_suspend(struct device *dev)
>> {
>> --
>> 2.25.1
>>
>

--
Regards,
Vincenzo