2020-03-11 01:10:31

by Jules Irenge

Subject: [PATCH 6/8] net: Add missing annotation for *netlink_seq_start()

Sparse reports a warning at netlink_seq_start()

warning: context imbalance in netlink_seq_start() - wrong count at exit
The root cause is the missing annotation at netlink_seq_start()
Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <[email protected]>
---
net/netlink/af_netlink.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 7a287dc73f63..99eef04a51ec 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2582,6 +2582,7 @@ static void *__netlink_seq_next(struct seq_file *seq)
}

static void *netlink_seq_start(struct seq_file *seq, loff_t *posp)
+ __acquires(RCU)
{
struct nl_seq_iter *iter = seq->private;
void *obj = SEQ_START_TOKEN;
--
2.24.1

2020-03-12 06:22:17

by David Miller

Subject: Re: [PATCH 6/8] net: Add missing annotation for *netlink_seq_start()

From: Jules Irenge <[email protected]>
Date: Wed, 11 Mar 2020 01:09:06 +0000

> Sparse reports a warning at netlink_seq_start()
>
> warning: context imbalance in netlink_seq_start() - wrong count at exit
> The root cause is the missing annotation at netlink_seq_start()
> Add the missing __acquires(RCU) annotation
>
> Signed-off-by: Jules Irenge <[email protected]>

Applied.