2020-03-11 07:03:50

by chenzhou

Subject: [PATCH -next] net: ibm: remove set but not used variables 'err'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
variable err set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/ethernet/ibm/emac/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index b7fc177..06248a7 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -872,7 +872,7 @@ static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
{
struct emac_regs __iomem *p = dev->emacp;
u32 r = 0;
- int n, err = -ETIMEDOUT;
+ int n;

mutex_lock(&dev->mdio_lock);

@@ -919,7 +919,6 @@ static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
goto bail;
}
}
- err = 0;
bail:
if (emac_has_feature(dev, EMAC_FTR_HAS_RGMII))
rgmii_put_mdio(dev->rgmii_dev, dev->rgmii_port);
--
2.7.4

2020-03-12 06:34:01

by David Miller

Subject: Re: [PATCH -next] net: ibm: remove set but not used variables 'err'

From: Chen Zhou <[email protected]>
Date: Wed, 11 Mar 2020 14:54:11 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
> drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
> variable err set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Chen Zhou <[email protected]>

Applied, thank you.