2020-03-07 00:21:57

by Kees Cook

Subject: [PATCH] fs_parse: Remove pr_notice() about each validation

This notice fills my boot logs with scary-looking asterisks but doesn't
really tell me anything. Let's just remove it; validation errors
are already reported separately, so this is just a redundant list of
filesystems.

$ dmesg | grep VALIDATE
[ 0.306256] *** VALIDATE tmpfs ***
[ 0.307422] *** VALIDATE proc ***
[ 0.308355] *** VALIDATE cgroup ***
[ 0.308741] *** VALIDATE cgroup2 ***
[ 0.813256] *** VALIDATE bpf ***
[ 0.815272] *** VALIDATE ramfs ***
[ 0.815665] *** VALIDATE hugetlbfs ***
[ 0.876970] *** VALIDATE nfs ***
[ 0.877383] *** VALIDATE nfs4 ***

Signed-off-by: Kees Cook <[email protected]>
---
fs/fs_parser.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/fs_parser.c b/fs/fs_parser.c
index 7e6fb43f9541..ab53e42a874a 100644
--- a/fs/fs_parser.c
+++ b/fs/fs_parser.c
@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
const struct fs_parameter_spec *param, *p2;
bool good = true;

- pr_notice("*** VALIDATE %s ***\n", name);
-
for (param = desc; param->name; param++) {
/* Check for duplicate parameter names */
for (p2 = desc; p2 < param; p2++) {
--
2.20.1


--
Kees Cook

2020-03-11 17:20:56

by Kees Cook

Subject: Re: [PATCH] fs_parse: Remove pr_notice() about each validation

Hi Andrew,

Can you pick this up in -mm?

Thanks!

-Kees

On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote:
> This notice fills my boot logs with scary-looking asterisks but doesn't
> really tell me anything. Let's just remove it; validation errors
> are already reported separately, so this is just a redundant list of
> filesystems.
>
> $ dmesg | grep VALIDATE
> [ 0.306256] *** VALIDATE tmpfs ***
> [ 0.307422] *** VALIDATE proc ***
> [ 0.308355] *** VALIDATE cgroup ***
> [ 0.308741] *** VALIDATE cgroup2 ***
> [ 0.813256] *** VALIDATE bpf ***
> [ 0.815272] *** VALIDATE ramfs ***
> [ 0.815665] *** VALIDATE hugetlbfs ***
> [ 0.876970] *** VALIDATE nfs ***
> [ 0.877383] *** VALIDATE nfs4 ***
>
> Signed-off-by: Kees Cook <[email protected]>
> ---
> fs/fs_parser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 7e6fb43f9541..ab53e42a874a 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
> const struct fs_parameter_spec *param, *p2;
> bool good = true;
>
> - pr_notice("*** VALIDATE %s ***\n", name);
> -
> for (param = desc; param->name; param++) {
> /* Check for duplicate parameter names */
> for (p2 = desc; p2 < param; p2++) {
> --
> 2.20.1
>
>
> --
> Kees Cook

--
Kees Cook

2020-03-11 18:04:51

by Seth Arnold

Subject: Re: [PATCH] fs_parse: Remove pr_notice() about each validation

On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote:
> This notice fills my boot logs with scary-looking asterisks but doesn't
> really tell me anything. Let's just remove it; validation errors
> are already reported separately, so this is just a redundant list of
> filesystems.
>
> $ dmesg | grep VALIDATE
> [ 0.306256] *** VALIDATE tmpfs ***
> [ 0.307422] *** VALIDATE proc ***
> [ 0.308355] *** VALIDATE cgroup ***
> [ 0.308741] *** VALIDATE cgroup2 ***
> [ 0.813256] *** VALIDATE bpf ***
> [ 0.815272] *** VALIDATE ramfs ***
> [ 0.815665] *** VALIDATE hugetlbfs ***
> [ 0.876970] *** VALIDATE nfs ***
> [ 0.877383] *** VALIDATE nfs4 ***
>
> Signed-off-by: Kees Cook <[email protected]>

Excellent, these messages haven't been useful in helping users diagnose
problems and they look quite noisy considering how mundane they are.

Reviewed-by: Seth Arnold <[email protected]>

Thanks

> ---
> fs/fs_parser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 7e6fb43f9541..ab53e42a874a 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
> const struct fs_parameter_spec *param, *p2;
> bool good = true;
>
> - pr_notice("*** VALIDATE %s ***\n", name);
> -
> for (param = desc; param->name; param++) {
> /* Check for duplicate parameter names */
> for (p2 = desc; p2 < param; p2++) {
> --
> 2.20.1
>
>
> --
> Kees Cook