2020-03-15 01:56:21

by saravanan sekar

Subject: [PATCH v2 1/5] dt-bindings: mfd: add document bindings for mp2629

Add device tree binding information for mp2629 mfd driver.

Signed-off-by: Saravanan Sekar <[email protected]>
---
.../devicetree/bindings/mfd/mps,mp2629.yaml | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml

diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
new file mode 100644
index 000000000000..f5b8c73123c6
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MP2629 Battery Charger PMIC from Monolithic Power System.
+
+maintainers:
+ - Saravanan Sekar <[email protected]>
+
+description: |
+ MP2629 is an PMIC providing battery charging and power supply for smartphones,
+ Wireless camera and portable devices. Chip is contrlled over I2C.
+
+ The MFD device handles battery charger controller and ADC IIO device for
+ battery, system voltage
+
+properties:
+ compatible:
+ const: mps,mp2629
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+ description:
+ The first cell is the IRQ number, the second cell is the trigger type.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/input/linux-event-codes.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@4b {
+ compatible = "mps,mp2629";
+ reg = <0x4b>;
+
+ interrupt-controller;
+ interrupt-parent = <&gpio2>;
+ #interrupt-cells = <2>;
+ interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
--
2.17.1

2020-03-15 10:22:04

by Jonathan Cameron

Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: add document bindings for mp2629

On Sun, 15 Mar 2020 01:00:09 +0100
Saravanan Sekar <[email protected]> wrote:

> Add device tree binding information for mp2629 mfd driver.
>
> Signed-off-by: Saravanan Sekar <[email protected]>
Trivial inline.

> ---
> .../devicetree/bindings/mfd/mps,mp2629.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
> new file mode 100644
> index 000000000000..f5b8c73123c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MP2629 Battery Charger PMIC from Monolithic Power System.
> +
> +maintainers:
> + - Saravanan Sekar <[email protected]>
> +
> +description: |
> + MP2629 is an PMIC providing battery charging and power supply for smartphones,
> + Wireless camera and portable devices. Chip is contrlled over I2C.

wireless (odd capitalization)

> +
> + The MFD device handles battery charger controller and ADC IIO device for
> + battery, system voltage
> +
> +properties:
> + compatible:
> + const: mps,mp2629
> +
> + reg:
> + description:
> + I2C device address.

Could drop the description. It's a standard element for an i2c device.

> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> + description:
> + The first cell is the IRQ number, the second cell is the trigger type.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/linux-event-codes.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@4b {
> + compatible = "mps,mp2629";
> + reg = <0x4b>;
> +
> + interrupt-controller;
> + interrupt-parent = <&gpio2>;
> + #interrupt-cells = <2>;
> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };