2020-03-16 03:48:10

by Zheng Wei

Subject: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

remove the duplicated definition of 'inode_item_err'
in the file tree-checker.c

Signed-off-by: Zheng Wei <[email protected]>
---

changelog
v1 -> v2
- resend for the failure of delivery to some recipients.

fs/btrfs/tree-checker.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index a92f8a6dd192..517b44300a05 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -957,10 +957,6 @@ static int check_dev_item(struct extent_buffer *leaf,
return 0;
}

-/* Inode item error output has the same format as dir_item_err() */
-#define inode_item_err(eb, slot, fmt, ...) \
- dir_item_err(eb, slot, fmt, __VA_ARGS__)
-
static int check_inode_item(struct extent_buffer *leaf,
struct btrfs_key *key, int slot)
{
--
2.17.1

2020-03-16 08:21:07

by Greg Kroah-Hartman

Subject: Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
>
> Signed-off-by: Zheng Wei <[email protected]>
> ---
>
> changelog
> v1 -> v2
> - resend for the failure of delivery to some recipients.
>
> fs/btrfs/tree-checker.c | 4 ----
> 1 file changed, 4 deletions(-)

Your choice of people to send this patch to is very odd:

$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
Chris Mason <[email protected]> (maintainer:BTRFS FILE SYSTEM)
Josef Bacik <[email protected]> (maintainer:BTRFS FILE SYSTEM)
David Sterba <[email protected]> (maintainer:BTRFS FILE SYSTEM)
[email protected] (open list:BTRFS FILE SYSTEM)
[email protected] (open list)


Please be more mindful.

thanks,

greg k-h

2020-03-16 09:28:23

by Zheng Wei

Subject: Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

From: Greg Kroah-Hartman <[email protected]>
Date: 2020-03-16 16:20:21
To: Zheng Wei <[email protected]>
Cc: Catalin Marinas <[email protected]>,Will Deacon <[email protected]>,Chris Mason <[email protected]>,Josef Bacik <[email protected]>,David Sterba <[email protected]>,Allison Randal <[email protected]>,Hanjun Guo <[email protected]>,Enrico Weigelt <[email protected]>,Yunfeng Ye <[email protected]>,Thomas Gleixner <[email protected]>,[email protected],[email protected],[email protected],[email protected],[email protected]
Subject: Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'>On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
>> remove the duplicated definition of 'inode_item_err'
>> in the file tree-checker.c
>>
>> Signed-off-by: Zheng Wei <[email protected]>
>> ---
>>
>> changelog
>> v1 -> v2
>> - resend for the failure of delivery to some recipients.
>>
>> fs/btrfs/tree-checker.c | 4 ----
>> 1 file changed, 4 deletions(-)
>
>Your choice of people to send this patch to is very odd:
>
>$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
>Chris Mason <[email protected]> (maintainer:BTRFS FILE SYSTEM)
>Josef Bacik <[email protected]> (maintainer:BTRFS FILE SYSTEM)
>David Sterba <[email protected]> (maintainer:BTRFS FILE SYSTEM)
>[email protected] (open list:BTRFS FILE SYSTEM)
>[email protected] (open list)
>
so sorry for this,
as a new submitter, I used 'scripts/get_maintainer.pl my patch' command to get the mailing list.
I'll pay more attention next time.

Thanks,
Zheng Wei
>
>Please be more mindful.
>
>thanks,
>
>greg k-h