2020-03-10 09:14:27

by Joerg Roedel

Subject: [PATCH 04/15] iommu/tegra-gart: Remove direct access of dev->iommu_fwspec

From: Joerg Roedel <[email protected]>

Use the accessor functions instead of directly dereferencing
dev->iommu_fwspec.

Signed-off-by: Joerg Roedel <[email protected]>
---
drivers/iommu/tegra-gart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 3fb7ba72507d..db6559e8336f 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -247,7 +247,7 @@ static int gart_iommu_add_device(struct device *dev)
{
struct iommu_group *group;

- if (!dev->iommu_fwspec)
+ if (!dev_iommu_fwspec_get(dev))
return -ENODEV;

group = iommu_group_get_for_dev(dev);
--
2.17.1

2020-03-16 15:44:57

by Jean-Philippe Brucker

Subject: Re: [PATCH 04/15] iommu/tegra-gart: Remove direct access of dev->iommu_fwspec

On Tue, Mar 10, 2020 at 10:12:18AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <[email protected]>
>
> Use the accessor functions instead of directly dereferencing
> dev->iommu_fwspec.
>
> Signed-off-by: Joerg Roedel <[email protected]>

Reviewed-by: Jean-Philippe Brucker <[email protected]>

> ---
> drivers/iommu/tegra-gart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
> index 3fb7ba72507d..db6559e8336f 100644
> --- a/drivers/iommu/tegra-gart.c
> +++ b/drivers/iommu/tegra-gart.c
> @@ -247,7 +247,7 @@ static int gart_iommu_add_device(struct device *dev)
> {
> struct iommu_group *group;
>
> - if (!dev->iommu_fwspec)
> + if (!dev_iommu_fwspec_get(dev))
> return -ENODEV;
>
> group = iommu_group_get_for_dev(dev);
> --
> 2.17.1
>