2020-03-16 17:35:22

by Ira Weiny

[permalink] [raw]
Subject: [RESEND] memremap: Remove stale comments

From: Ira Weiny <[email protected]>

Fixes: 80a72d0af05a ("memremap: remove the data field in struct dev_pagemap")
Fixes: fdc029b19dfd ("memremap: remove the dev field in struct dev_pagemap")
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Ira Weiny <[email protected]>

---
Resending as I don't see this picked up in the rdma tree.

Jason I sent this to you as you pulled the patches which dropped the
parameters. Can you take it? Or do you want me to send through Andrew?

Thanks,
Ira

include/linux/memremap.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index 6fefb09af7c3..edfd1ec6c165 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -98,8 +98,6 @@ struct dev_pagemap_ops {
* @ref: reference count that pins the devm_memremap_pages() mapping
* @internal_ref: internal reference if @ref is not provided by the caller
* @done: completion for @internal_ref
- * @dev: host device of the mapping for debug
- * @data: private data pointer for page_free()
* @type: memory type: see MEMORY_* in memory_hotplug.h
* @flags: PGMAP_* flags to specify defailed behavior
* @ops: method table
--
2.23.0


2020-03-16 18:22:10

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [RESEND] memremap: Remove stale comments

On Mon, Mar 16, 2020 at 10:34:14AM -0700, [email protected] wrote:
> From: Ira Weiny <[email protected]>
>
> Fixes: 80a72d0af05a ("memremap: remove the data field in struct dev_pagemap")
> Fixes: fdc029b19dfd ("memremap: remove the dev field in struct dev_pagemap")
> Reviewed-by: Christoph Hellwig <[email protected]>
> Signed-off-by: Ira Weiny <[email protected]>
>
> Resending as I don't see this picked up in the rdma tree.
>
> Jason I sent this to you as you pulled the patches which dropped the
> parameters. Can you take it? Or do you want me to send through Andrew?

To Andrew please, hmm tree should only step outside to manage
conflicts connected to hmm related patches.

Thanks,
Jason