2020-03-17 06:56:27

by Zhenyu Wang

[permalink] [raw]
Subject: [PATCH] KVM: x86: Expose AVX512 VP2INTERSECT in cpuid for TGL

On Tigerlake new AVX512 VP2INTERSECT feature is available.
This would expose it for KVM supported cpuid.

Cc: "Zhong, Yang" <[email protected]>
Signed-off-by: Zhenyu Wang <[email protected]>
---
arch/x86/kvm/cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index b1c469446b07..b4e25ff6ab0a 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -374,7 +374,7 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry, int index)
const u32 kvm_cpuid_7_0_edx_x86_features =
F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) |
- F(MD_CLEAR);
+ F(MD_CLEAR) | F(AVX512_VP2INTERSECT);

/* cpuid 7.1.eax */
const u32 kvm_cpuid_7_1_eax_x86_features =
--
2.25.0.rc2


2020-03-17 08:34:24

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH] KVM: x86: Expose AVX512 VP2INTERSECT in cpuid for TGL

On 17/03/20 07:55, Zhenyu Wang wrote:
> On Tigerlake new AVX512 VP2INTERSECT feature is available.
> This would expose it for KVM supported cpuid.
>
> Cc: "Zhong, Yang" <[email protected]>
> Signed-off-by: Zhenyu Wang <[email protected]>
> ---
> arch/x86/kvm/cpuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index b1c469446b07..b4e25ff6ab0a 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -374,7 +374,7 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry, int index)
> const u32 kvm_cpuid_7_0_edx_x86_features =
> F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
> F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) |
> - F(MD_CLEAR);
> + F(MD_CLEAR) | F(AVX512_VP2INTERSECT);
>
> /* cpuid 7.1.eax */
> const u32 kvm_cpuid_7_1_eax_x86_features =
>

Hi Zhenyu,

please rebase - the CPUID mechanism is completely rewritten in kvm/queue.

Thanks,

Paolo

2020-03-18 03:29:21

by Zhenyu Wang

[permalink] [raw]
Subject: [PATCH rebase] KVM: x86: Expose AVX512 VP2INTERSECT in cpuid for TGL

On Tigerlake new AVX512 VP2INTERSECT feature is available.
This trys to expose it for KVM supported cpuid.

Cc: "Zhong, Yang" <[email protected]>
Signed-off-by: Zhenyu Wang <[email protected]>
---
arch/x86/kvm/cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 08280d8a2ac9..435a7da07d5f 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -338,7 +338,7 @@ void kvm_set_cpu_caps(void)
kvm_cpu_cap_mask(CPUID_7_EDX,
F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) |
- F(MD_CLEAR)
+ F(MD_CLEAR) | F(AVX512_VP2INTERSECT)
);

/* TSC_ADJUST and ARCH_CAPABILITIES are emulated in software. */
--
2.25.1

2020-03-18 11:27:44

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH rebase] KVM: x86: Expose AVX512 VP2INTERSECT in cpuid for TGL

On 18/03/20 04:27, Zhenyu Wang wrote:
> On Tigerlake new AVX512 VP2INTERSECT feature is available.
> This trys to expose it for KVM supported cpuid.
>
> Cc: "Zhong, Yang" <[email protected]>
> Signed-off-by: Zhenyu Wang <[email protected]>
> ---
> arch/x86/kvm/cpuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 08280d8a2ac9..435a7da07d5f 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -338,7 +338,7 @@ void kvm_set_cpu_caps(void)
> kvm_cpu_cap_mask(CPUID_7_EDX,
> F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
> F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) |
> - F(MD_CLEAR)
> + F(MD_CLEAR) | F(AVX512_VP2INTERSECT)
> );
>
> /* TSC_ADJUST and ARCH_CAPABILITIES are emulated in software. */
>

Queued, thanks.

Paolo