2020-03-17 04:54:43

by Anson Huang

Subject: [PATCH] cpufreq: imx6q-cpufreq: Improve the logic of -EPROBE_DEFER handling

Improve the -EPROBE_DEFER handling logic to simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/cpufreq/imx6q-cpufreq.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
index 285b8e9..fdb2fff 100644
--- a/drivers/cpufreq/imx6q-cpufreq.c
+++ b/drivers/cpufreq/imx6q-cpufreq.c
@@ -400,11 +400,9 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
ret = imx6q_opp_check_speed_grading(cpu_dev);
}
if (ret) {
- if (ret == -EPROBE_DEFER)
- goto out_free_opp;
-
- dev_err(cpu_dev, "failed to read ocotp: %d\n",
- ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(cpu_dev, "failed to read ocotp: %d\n",
+ ret);
goto out_free_opp;
}

--
2.7.4

2020-03-17 08:04:24

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: imx6q-cpufreq: Improve the logic of -EPROBE_DEFER handling

On 17-03-20, 12:38, Anson Huang wrote:
> Improve the -EPROBE_DEFER handling logic to simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 285b8e9..fdb2fff 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -400,11 +400,9 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
> ret = imx6q_opp_check_speed_grading(cpu_dev);
> }
> if (ret) {
> - if (ret == -EPROBE_DEFER)
> - goto out_free_opp;
> -
> - dev_err(cpu_dev, "failed to read ocotp: %d\n",
> - ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(cpu_dev, "failed to read ocotp: %d\n",
> + ret);
> goto out_free_opp;
> }

Applied. Thanks.


--
viresh