2020-03-17 09:51:50

by Rayagonda Kokatanur

Subject: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment

Remove unused variable assignment.

Signed-off-by: Rayagonda Kokatanur <[email protected]>
---
Changes from v1:
- Address code review comment from Sergei Shtylyov,
Correct the commit message.

drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);

while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);

/* Fill additional invoke cmd params */
--
2.17.1

2020-03-17 19:34:45

by Tyler Hicks

Subject: Re: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment

On 2020-03-17 15:20:37, Rayagonda Kokatanur wrote:
> Remove unused variable assignment.
>
> Signed-off-by: Rayagonda Kokatanur <[email protected]>

Reviewed-by: Tyler Hicks <[email protected]>

Tyler

> ---
> Changes from v1:
> - Address code review comment from Sergei Shtylyov,
> Correct the commit message.
>
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>
> while (rbytes) {
> - nbytes = rbytes;
> -
> nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>
> /* Fill additional invoke cmd params */
> --
> 2.17.1
>