2020-03-13 23:07:07

by Vivek Unune

Subject: [PATCH v2] arm64: dts: rockchip: Add Hugsun X99 IR receiver and power led

- Add Hugsun X99 IR receiver and power led
- Remove pwm0 node as it interferes with power LED gpio
pwm0 is not used in factory firmware as well

Tested with LibreElec linux-next-20200305

Signed-off-by: Vivek Unune <[email protected]>
---
Changes in v2:
- Changed led trigger from none to default-on
- Changed led node name from power-led to led-0
---
.../boot/dts/rockchip/rk3399-hugsun-x99.dts | 37 +++++++++++++++++--
1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
index d69a613fb65a..df425e164a2e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
@@ -29,6 +29,26 @@
regulator-max-microvolt = <5000000>;
};

+ ir-receiver {
+ compatible = "gpio-ir-receiver";
+ gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ir_rx>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&power_led_gpio>;
+
+ led-0 {
+ label = "blue:power";
+ gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ linux,default-trigger = "default-on";
+ };
+ };
+
vcc_sys: vcc-sys {
compatible = "regulator-fixed";
regulator-name = "vcc_sys";
@@ -483,6 +503,18 @@
};
};

+ ir {
+ ir_rx: ir-rx {
+ rockchip,pins = <0 RK_PA6 1 &pcfg_pull_none>;
+ };
+ };
+
+ leds {
+ power_led_gpio: power-led-gpio {
+ rockchip,pins = <4 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
pmic {
pmic_int_l: pmic-int-l {
rockchip,pins =
@@ -539,10 +572,6 @@
};
};

-&pwm0 {
- status = "okay";
-};
-
&pwm2 {
status = "okay";
pinctrl-0 = <&pwm2_pin_pull_down>;
--
2.20.1

2020-03-17 01:08:07

by Heiko Stuebner

Subject: Re: [PATCH v2] arm64: dts: rockchip: Add Hugsun X99 IR receiver and power led

Am Samstag, 14. M?rz 2020, 00:05:13 CET schrieb Vivek Unune:
> - Add Hugsun X99 IR receiver and power led
> - Remove pwm0 node as it interferes with power LED gpio
> pwm0 is not used in factory firmware as well
>
> Tested with LibreElec linux-next-20200305
>
> Signed-off-by: Vivek Unune <[email protected]>

I've applied this for 5.7, but did split the patch into two.
One for the addition of the IR and a second for led.

Please do similar for future patches.

Thanks
Heiko

2020-03-17 13:33:50

by Vivek Unune

Subject: Re: [PATCH v2] arm64: dts: rockchip: Add Hugsun X99 IR receiver and power led

On Tue, Mar 17, 2020 at 01:54:52AM +0100, Heiko Stuebner wrote:
> Am Samstag, 14. M?rz 2020, 00:05:13 CET schrieb Vivek Unune:
> > - Add Hugsun X99 IR receiver and power led
> > - Remove pwm0 node as it interferes with power LED gpio
> > pwm0 is not used in factory firmware as well
> >
> > Tested with LibreElec linux-next-20200305
> >
> > Signed-off-by: Vivek Unune <[email protected]>
>
> I've applied this for 5.7, but did split the patch into two.
> One for the addition of the IR and a second for led.
>
> Please do similar for future patches.
>
> Thanks
> Heiko
>
>

Hi Heiko,

Much appriciated. I'll make sure to do that with my future patches

Thanks,

Vivek