2020-03-18 09:37:30

by Zhiqiang Hou

[permalink] [raw]
Subject: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT

From: Hou Zhiqiang <[email protected]>

Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
into PCIE_MOBIVEIL_PLAT.

WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]

Signed-off-by: Hou Zhiqiang <[email protected]>
---
drivers/pci/controller/mobiveil/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
index 7439991ee82c..a62d247018cf 100644
--- a/drivers/pci/controller/mobiveil/Kconfig
+++ b/drivers/pci/controller/mobiveil/Kconfig
@@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
bool "Mobiveil AXI PCIe controller"
depends on ARCH_ZYNQMP || COMPILE_TEST
depends on OF
+ depends on PCI_MSI_IRQ_DOMAIN
select PCIE_MOBIVEIL_HOST
help
Say Y here if you want to enable support for the Mobiveil AXI PCIe
--
2.17.1


2020-03-18 10:36:41

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT

On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <[email protected]>
>
> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> into PCIE_MOBIVEIL_PLAT.
>
> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> Selected by [y]:
> - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
>
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> drivers/pci/controller/mobiveil/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

I have applied it to pci/mobiveil for v5.7.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
> index 7439991ee82c..a62d247018cf 100644
> --- a/drivers/pci/controller/mobiveil/Kconfig
> +++ b/drivers/pci/controller/mobiveil/Kconfig
> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
> bool "Mobiveil AXI PCIe controller"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on OF
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_MOBIVEIL_HOST
> help
> Say Y here if you want to enable support for the Mobiveil AXI PCIe
> --
> 2.17.1
>

2020-03-18 16:29:11

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT

On 3/18/20 3:35 AM, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
>> From: Hou Zhiqiang <[email protected]>
>>
>> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
>> into PCIE_MOBIVEIL_PLAT.
>>
>> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>> Selected by [y]:
>> - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
>>
>> Signed-off-by: Hou Zhiqiang <[email protected]>
>> ---
>> drivers/pci/controller/mobiveil/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>
> I have applied it to pci/mobiveil for v5.7.

Reported-by: Randy Dunlap <[email protected]>
Acked-by: Randy Dunlap <[email protected]> # build-tested

Thanks.

> Thanks,
> Lorenzo
>
>> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
>> index 7439991ee82c..a62d247018cf 100644
>> --- a/drivers/pci/controller/mobiveil/Kconfig
>> +++ b/drivers/pci/controller/mobiveil/Kconfig
>> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>> bool "Mobiveil AXI PCIe controller"
>> depends on ARCH_ZYNQMP || COMPILE_TEST
>> depends on OF
>> + depends on PCI_MSI_IRQ_DOMAIN
>> select PCIE_MOBIVEIL_HOST
>> help
>> Say Y here if you want to enable support for the Mobiveil AXI PCIe
>> --
>> 2.17.1
>>


--
~Randy

2020-03-18 16:31:33

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT

On Wed, Mar 18, 2020 at 10:35:16AM +0000, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <[email protected]>
> >
> > Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> > into PCIE_MOBIVEIL_PLAT.
> >
> > WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
> > Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> > Selected by [y]:
> > - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
> >
> > Signed-off-by: Hou Zhiqiang <[email protected]>
> > ---
> > drivers/pci/controller/mobiveil/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> I have applied it to pci/mobiveil for v5.7.

Thanks, I updated my "next" branch with this.