2020-03-20 10:21:20

by Michal Suchánek

[permalink] [raw]
Subject: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

While at it also simplify the existing perf patterns.

Signed-off-by: Michal Suchanek <[email protected]>
---
v10: new patch
V12: remove redundant entries
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e1a99197fb34..578429d22220 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13080,7 +13080,7 @@ R: Namhyung Kim <[email protected]>
L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
S: Supported
-F: kernel/events/*
+F: kernel/events/
F: include/linux/perf_event.h
F: include/uapi/linux/perf_event.h
F: arch/*/kernel/perf_event*.c
@@ -13088,8 +13088,8 @@ F: arch/*/kernel/*/perf_event*.c
F: arch/*/kernel/*/*/perf_event*.c
F: arch/*/include/asm/perf_event.h
F: arch/*/kernel/perf_callchain.c
-F: arch/*/events/*
-F: arch/*/events/*/*
+F: arch/*/events/
+F: arch/*/perf/
F: tools/perf/

PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
--
2.23.0


2020-03-20 10:35:12

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> While at it also simplify the existing perf patterns.
>

And still missed fixes from parse-maintainers.pl.

I see it like below in the linux-next (after the script)

PERFORMANCE EVENTS SUBSYSTEM
M: Peter Zijlstra <[email protected]>
M: Ingo Molnar <[email protected]>
M: Arnaldo Carvalho de Melo <[email protected]>
R: Mark Rutland <[email protected]>
R: Alexander Shishkin <[email protected]>
R: Jiri Olsa <[email protected]>
R: Namhyung Kim <[email protected]>
L: [email protected]
S: Supported
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
F: arch/*/events/*
F: arch/*/events/*/*
F: arch/*/include/asm/perf_event.h
F: arch/*/kernel/*/*/perf_event*.c
F: arch/*/kernel/*/perf_event*.c
F: arch/*/kernel/perf_callchain.c
F: arch/*/kernel/perf_event*.c
F: include/linux/perf_event.h
F: include/uapi/linux/perf_event.h
F: kernel/events/*
F: tools/perf/

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13080,7 +13080,7 @@ R: Namhyung Kim <[email protected]>
> L: [email protected]
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> S: Supported
> -F: kernel/events/*
> +F: kernel/events/
> F: include/linux/perf_event.h
> F: include/uapi/linux/perf_event.h
> F: arch/*/kernel/perf_event*.c
> @@ -13088,8 +13088,8 @@ F: arch/*/kernel/*/perf_event*.c
> F: arch/*/kernel/*/*/perf_event*.c
> F: arch/*/include/asm/perf_event.h
> F: arch/*/kernel/perf_callchain.c
> -F: arch/*/events/*
> -F: arch/*/events/*/*
> +F: arch/*/events/
> +F: arch/*/perf/
> F: tools/perf/
>
> PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS

--
With Best Regards,
Andy Shevchenko


2020-03-20 11:24:25

by Michal Suchánek

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > While at it also simplify the existing perf patterns.
> >
>
> And still missed fixes from parse-maintainers.pl.

Oh, that script UX is truly ingenious. It provides no output and quietly
creates MAINTAINERS.new which is, of course, not included in the patch.

Thanks

Michal

>
> I see it like below in the linux-next (after the script)
>
> PERFORMANCE EVENTS SUBSYSTEM
> M: Peter Zijlstra <[email protected]>
> M: Ingo Molnar <[email protected]>
> M: Arnaldo Carvalho de Melo <[email protected]>
> R: Mark Rutland <[email protected]>
> R: Alexander Shishkin <[email protected]>
> R: Jiri Olsa <[email protected]>
> R: Namhyung Kim <[email protected]>
> L: [email protected]
> S: Supported
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> F: arch/*/events/*
> F: arch/*/events/*/*
> F: arch/*/include/asm/perf_event.h
> F: arch/*/kernel/*/*/perf_event*.c
> F: arch/*/kernel/*/perf_event*.c
> F: arch/*/kernel/perf_callchain.c
> F: arch/*/kernel/perf_event*.c
> F: include/linux/perf_event.h
> F: include/uapi/linux/perf_event.h
> F: kernel/events/*
> F: tools/perf/
>
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13080,7 +13080,7 @@ R: Namhyung Kim <[email protected]>
> > L: [email protected]
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> > S: Supported
> > -F: kernel/events/*
> > +F: kernel/events/
> > F: include/linux/perf_event.h
> > F: include/uapi/linux/perf_event.h
> > F: arch/*/kernel/perf_event*.c
> > @@ -13088,8 +13088,8 @@ F: arch/*/kernel/*/perf_event*.c
> > F: arch/*/kernel/*/*/perf_event*.c
> > F: arch/*/include/asm/perf_event.h
> > F: arch/*/kernel/perf_callchain.c
> > -F: arch/*/events/*
> > -F: arch/*/events/*/*
> > +F: arch/*/events/
> > +F: arch/*/perf/
> > F: tools/perf/
> >
> > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

2020-03-20 12:43:45

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > While at it also simplify the existing perf patterns.

> > And still missed fixes from parse-maintainers.pl.
>
> Oh, that script UX is truly ingenious.

You have at least two options, their combinations, etc:
- complain to the author :-)
- send a patch :-)

> It provides no output and quietly
> creates MAINTAINERS.new which is, of course, not included in the patch.

Yes. it also took me a while to understand how it works, luckily it has a
little help note.

--
With Best Regards,
Andy Shevchenko


2020-03-20 14:44:58

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > While at it also simplify the existing perf patterns.
> > > And still missed fixes from parse-maintainers.pl.
> >
> > Oh, that script UX is truly ingenious.
>
> You have at least two options, their combinations, etc:
> - complain to the author :-)
> - send a patch :-)

Recently:

https://lore.kernel.org/lkml/[email protected]/


2020-03-20 16:29:02

by Michal Suchánek

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote:
> On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > > While at it also simplify the existing perf patterns.
> > > > And still missed fixes from parse-maintainers.pl.
> > >
> > > Oh, that script UX is truly ingenious.
> >
> > You have at least two options, their combinations, etc:
> > - complain to the author :-)
> > - send a patch :-)
>
> Recently:
>
> https://lore.kernel.org/lkml/[email protected]/

Can we expect that reaordering is taken care of in that discussion then?

Thanks

Michal

2020-03-20 16:34:27

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote:
> On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > > While at it also simplify the existing perf patterns.
> > > > And still missed fixes from parse-maintainers.pl.
> > >
> > > Oh, that script UX is truly ingenious.
> >
> > You have at least two options, their combinations, etc:
> > - complain to the author :-)
> > - send a patch :-)
>
> Recently:
>
> https://lore.kernel.org/lkml/[email protected]/

But why?

Shouldn't we rather run MAINTAINERS clean up once and require people to use
parse-maintainers.pl for good?

--
With Best Regards,
Andy Shevchenko


2020-03-20 16:43:38

by Michal Suchánek

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 06:31:57PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote:
> > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > > > While at it also simplify the existing perf patterns.
> > > > > And still missed fixes from parse-maintainers.pl.
> > > >
> > > > Oh, that script UX is truly ingenious.
> > >
> > > You have at least two options, their combinations, etc:
> > > - complain to the author :-)
> > > - send a patch :-)
> >
> > Recently:
> >
> > https://lore.kernel.org/lkml/[email protected]/
>
> But why?
>
> Shouldn't we rather run MAINTAINERS clean up once and require people to use
> parse-maintainers.pl for good?

That cleanup did not happen yet, and I am not volunteering for one.
The difference between MAINTAINERS and MAINTAINERS.new is:

MAINTAINERS | 5510 +++++++++++++++++++++++++++++------------------------------
1 file changed, 2755 insertions(+), 2755 deletions(-)

Thanks

Michal

2020-03-20 16:48:15

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, Mar 20, 2020 at 05:42:04PM +0100, Michal Such?nek wrote:
> On Fri, Mar 20, 2020 at 06:31:57PM +0200, Andy Shevchenko wrote:
> > On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote:
> > > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> > > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > > > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > > > > While at it also simplify the existing perf patterns.
> > > > > > And still missed fixes from parse-maintainers.pl.
> > > > >
> > > > > Oh, that script UX is truly ingenious.
> > > >
> > > > You have at least two options, their combinations, etc:
> > > > - complain to the author :-)
> > > > - send a patch :-)
> > >
> > > Recently:
> > >
> > > https://lore.kernel.org/lkml/[email protected]/
> >
> > But why?
> >
> > Shouldn't we rather run MAINTAINERS clean up once and require people to use
> > parse-maintainers.pl for good?
>
> That cleanup did not happen yet, and I am not volunteering for one.
> The difference between MAINTAINERS and MAINTAINERS.new is:
>
> MAINTAINERS | 5510 +++++++++++++++++++++++++++++------------------------------
> 1 file changed, 2755 insertions(+), 2755 deletions(-)

Yes, it was basically reply to Joe.

--
With Best Regards,
Andy Shevchenko


2020-03-20 21:39:38

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

(removed a bunch of cc's)

On Fri, 2020-03-20 at 18:31 +0200, Andy Shevchenko wrote:
> On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote:
> > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote:
> > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Such?nek wrote:
> > > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote:
> > > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote:
> > > > > > While at it also simplify the existing perf patterns.
> > > > > And still missed fixes from parse-maintainers.pl.
> > > >
> > > > Oh, that script UX is truly ingenious.
> > >
> > > You have at least two options, their combinations, etc:
> > > - complain to the author :-)
> > > - send a patch :-)
> >
> > Recently:
> >
> > https://lore.kernel.org/lkml/[email protected]/
>
> But why?
>
> Shouldn't we rather run MAINTAINERS clean up once and require people to use
> parse-maintainers.pl for good?

That can basically only be done by Linus just before he releases
an RC1.

I am for it. One day...