2020-03-21 18:10:11

by Keyur Patel

Subject: [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent

Since the commit 7723f4c ("driver core: platform: Add an error message
to platform_get_irq*()") platform_get_irq() started issuing an error message.
Thus, there is no need to have the same in the driver.

Signed-off-by: Keyur Patel <[email protected]>
---
drivers/rtc/rtc-bd70528.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c
index bbbb1f07c91f..4492b770422c 100644
--- a/drivers/rtc/rtc-bd70528.c
+++ b/drivers/rtc/rtc-bd70528.c
@@ -542,10 +542,8 @@ static int bd70528_probe(struct platform_device *pdev)

irq = platform_get_irq_byname(pdev, irq_name);

- if (irq < 0) {
- dev_err(&pdev->dev, "Failed to get irq\n");
+ if (irq < 0)
return irq;
- }

platform_set_drvdata(pdev, bd_rtc);

--
2.25.0

2020-03-22 21:18:05

by Alexandre Belloni

Subject: Re: [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent

On 21/03/2020 14:08:37-0400, Keyur Patel wrote:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
>
> Signed-off-by: Keyur Patel <[email protected]>
> ---
> drivers/rtc/rtc-bd70528.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com