2020-03-06 13:24:14

by Serge Semin

[permalink] [raw]
Subject: [PATCH 5/6] i2c: designware: Discard i2c_dw_read_comp_param() function

From: Serge Semin <[email protected]>

There is no code left in the kernel which would be using the function.
So just remove it.

Signed-off-by: Serge Semin <[email protected]>
Signed-off-by: Alexey Malahov <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: Paul Burton <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/i2c/busses/i2c-designware-common.c | 6 ------
drivers/i2c/busses/i2c-designware-core.h | 1 -
2 files changed, 7 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index 4291ff6246d8..72e93c1aa9bc 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -388,11 +388,5 @@ void i2c_dw_disable_int(struct dw_i2c_dev *dev)
dw_writel(dev, 0, DW_IC_INTR_MASK);
}

-u32 i2c_dw_read_comp_param(struct dw_i2c_dev *dev)
-{
- return dw_readl(dev, DW_IC_COMP_PARAM_1);
-}
-EXPORT_SYMBOL_GPL(i2c_dw_read_comp_param);
-
MODULE_DESCRIPTION("Synopsys DesignWare I2C bus adapter core");
MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
index 3fbc9f22fcf1..b220ad64c38d 100644
--- a/drivers/i2c/busses/i2c-designware-core.h
+++ b/drivers/i2c/busses/i2c-designware-core.h
@@ -314,7 +314,6 @@ static inline void __i2c_dw_disable_nowait(struct dw_i2c_dev *dev)

void __i2c_dw_disable(struct dw_i2c_dev *dev);

-extern u32 i2c_dw_read_comp_param(struct dw_i2c_dev *dev);
extern int i2c_dw_probe(struct dw_i2c_dev *dev);
#if IS_ENABLED(CONFIG_I2C_DESIGNWARE_SLAVE)
extern int i2c_dw_probe_slave(struct dw_i2c_dev *dev);
--
2.25.1


2020-03-12 14:51:13

by Jarkko Nikula

[permalink] [raw]
Subject: Re: [PATCH 5/6] i2c: designware: Discard i2c_dw_read_comp_param() function

On 3/6/20 3:19 PM, [email protected] wrote:
> From: Serge Semin <[email protected]>
>
> There is no code left in the kernel which would be using the function.
> So just remove it.
>
> Signed-off-by: Serge Semin <[email protected]>
> Signed-off-by: Alexey Malahov <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Paul Burton <[email protected]>
> Cc: Ralf Baechle <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/i2c/busses/i2c-designware-common.c | 6 ------
> drivers/i2c/busses/i2c-designware-core.h | 1 -
> 2 files changed, 7 deletions(-)
>
Acked-by: Jarkko Nikula <[email protected]>

2020-03-21 18:34:20

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 5/6] i2c: designware: Discard i2c_dw_read_comp_param() function

On Fri, Mar 06, 2020 at 04:19:56PM +0300, [email protected] wrote:
> From: Serge Semin <[email protected]>
>
> There is no code left in the kernel which would be using the function.
> So just remove it.
>
> Signed-off-by: Serge Semin <[email protected]>
> Signed-off-by: Alexey Malahov <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Paul Burton <[email protected]>
> Cc: Ralf Baechle <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Applied to for-next, thanks!


Attachments:
(No filename) (625.00 B)
signature.asc (849.00 B)
Download all attachments