2020-03-22 09:24:21

by John B. Wyatt IV

Subject: [PATCH] staging: vt6656: remove unneeded variable: ret

Remove unneeded variable ret; replace with 0 for the return value.

Update function documentation (comment) on the return status as
suggested by Julia Lawall <[email protected]>.

Issue reported by coccinelle (coccicheck).

Signed-off-by: John B. Wyatt IV <[email protected]>
---
drivers/staging/vt6656/card.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index dc3ab10eb630..05b57a2489a0 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -716,13 +716,11 @@ int vnt_radio_power_off(struct vnt_private *priv)
* Out:
* none
*
- * Return Value: true if success; otherwise false
+ * Return Value: 0
*
*/
int vnt_radio_power_on(struct vnt_private *priv)
{
- int ret = 0;
-
vnt_exit_deep_sleep(priv);

vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
@@ -741,7 +739,7 @@ int vnt_radio_power_on(struct vnt_private *priv)

vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);

- return ret;
+ return 0;
}

void vnt_set_bss_mode(struct vnt_private *priv)
--
2.25.1

2020-03-22 11:29:21

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vt6656: remove unneeded variable: ret

On Sun, Mar 22, 2020 at 02:23:03AM -0700, John B. Wyatt IV wrote:
> Remove unneeded variable ret; replace with 0 for the return value.
>
> Update function documentation (comment) on the return status as
> suggested by Julia Lawall <[email protected]>.
>
> Issue reported by coccinelle (coccicheck).
>
> Signed-off-by: John B. Wyatt IV <[email protected]>
> ---
> drivers/staging/vt6656/card.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index dc3ab10eb630..05b57a2489a0 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -716,13 +716,11 @@ int vnt_radio_power_off(struct vnt_private *priv)
> * Out:
> * none
> *
> - * Return Value: true if success; otherwise false
> + * Return Value: 0

If this always returns something, why have it return anything at all?

Why not make this a patch series, doing this, and then fixing up the
callers and the function to not return anything.

thanks,

greg k-h