2019-11-09 07:56:00

by Chuhong Yuan

[permalink] [raw]

Subject: [PATCH] i2c: ismt: Add missed pci_release_region

---

ismt_remove forgets to call pci_release_region when remove.
Add the call to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/i2c/busses/i2c-ismt.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 2f95e25a10f7..c393e629cac3 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
struct ismt_priv *priv = pci_get_drvdata(pdev);

i2c_del_adapter(&priv->adapter);
+
+ pci_release_region(pdev, SMBBAR);
}

static struct pci_driver ismt_driver = {
--
2.23.0

2020-03-22 16:09:03

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH] i2c: ismt: Add missed pci_release_region

---

On Sat, Nov 09, 2019 at 03:54:35PM +0800, Chuhong Yuan wrote:
> ismt_remove forgets to call pci_release_region when remove.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Chuhong Yuan, your To-Header is broken, so you never got a response.

Adding the maintainers to CC.

> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 2f95e25a10f7..c393e629cac3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
> struct ismt_priv *priv = pci_get_drvdata(pdev);
>
> i2c_del_adapter(&priv->adapter);
> +
> + pci_release_region(pdev, SMBBAR);
> }
>
> static struct pci_driver ismt_driver = {
> --
> 2.23.0
>

---

Attachments:

(No filename) (891.00 B)
signature.asc (849.00 B)
Download all attachments