2020-03-22 20:59:27

by Florian Fainelli

Subject: [PATCH net] net: dsa: Fix duplicate frames flooded by learning

When both the switch and the bridge are learning about new addresses,
switch ports attached to the bridge would see duplicate ARP frames
because both entities would attempt to send them.

Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
Reported-by: Maxime Bizon <[email protected]>
Signed-off-by: Florian Fainelli <[email protected]>
---
net/dsa/tag_brcm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
index 9c3114179690..9169b63a89e3 100644
--- a/net/dsa/tag_brcm.c
+++ b/net/dsa/tag_brcm.c
@@ -140,6 +140,8 @@ static struct sk_buff *brcm_tag_rcv_ll(struct sk_buff *skb,
/* Remove Broadcom tag and update checksum */
skb_pull_rcsum(skb, BRCM_TAG_LEN);

+ skb->offload_fwd_mark = 1;
+
return skb;
}
#endif
--
2.19.1

2020-03-23 18:24:22

by Vivien Didelot

Subject: Re: [PATCH net] net: dsa: Fix duplicate frames flooded by learning

On Sun, 22 Mar 2020 13:58:50 -0700, Florian Fainelli <[email protected]> wrote:
> When both the switch and the bridge are learning about new addresses,
> switch ports attached to the bridge would see duplicate ARP frames
> because both entities would attempt to send them.
>
> Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
> Reported-by: Maxime Bizon <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Vivien Didelot <[email protected]>

2020-03-24 04:48:58

by David Miller

Subject: Re: [PATCH net] net: dsa: Fix duplicate frames flooded by learning

From: Florian Fainelli <[email protected]>
Date: Sun, 22 Mar 2020 13:58:50 -0700

> When both the switch and the bridge are learning about new addresses,
> switch ports attached to the bridge would see duplicate ARP frames
> because both entities would attempt to send them.
>
> Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler")
> Reported-by: Maxime Bizon <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

Applied and queued up for -stable.