2020-03-25 20:55:09

by Simran Singhal

Subject: [PATCH] staging: rtl8723bs: rtw_efuse: Compress lines for immediate return

Compress two lines into a single line if immediate return statement is found.

It is done using script Coccinelle. And coccinelle uses following semantic
patch for this compression function:

@@
expression ret;
identifier f;
@@

-ret =
+return
f(...);
-return ret;

Signed-off-by: Simran Singhal <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index de7d15fdc936..8794638468e6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -266,8 +266,7 @@ bool bPseudoTest)
/* DBG_871X("===> EFUSE_OneByteRead() start, 0x34 = 0x%X\n", rtw_read32(padapter, EFUSE_TEST)); */

if (bPseudoTest) {
- bResult = Efuse_Read1ByteFromFakeContent(padapter, addr, data);
- return bResult;
+ return Efuse_Read1ByteFromFakeContent(padapter, addr, data);
}

/* <20130121, Kordan> For SMIC EFUSE specificatoin. */
@@ -319,8 +318,7 @@ bool bPseudoTest)
/* DBG_871X("===> EFUSE_OneByteWrite() start, 0x34 = 0x%X\n", rtw_read32(padapter, EFUSE_TEST)); */

if (bPseudoTest) {
- bResult = Efuse_Write1ByteToFakeContent(padapter, addr, data);
- return bResult;
+ return Efuse_Write1ByteToFakeContent(padapter, addr, data);
}


--
2.17.1

2020-03-30 06:48:35

by Stefano Brivio

Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: rtw_efuse: Compress lines for immediate return

On Thu, 26 Mar 2020 02:24:18 +0530
Simran Singhal <[email protected]> wrote:

> Compress two lines into a single line if immediate return statement is found.

Same as your patches for issues reported by checkpatch, I think you
should post these ones as a patchset.

--
Stefano