2020-03-28 16:45:11

by George Spelvin

[permalink] [raw]
Subject: [RFC PATCH v1 25/50] HID: hid-lg: We only need pseudorandom bytes for the address

It's just to reduce collisions among cooperating USB HID
devices; it's not intended to be secure against a malicious
attacker (and it would need to be a lot larger than 16 bits
if it were).

Signed-off-by: George Spelvin <[email protected]>
Cc: Simon Wood <[email protected]>
Cc: Hans de Goede <[email protected]>
Cc: Jiri Kosina <[email protected]>
Cc: Benjamin Tissoires <[email protected]>
---
drivers/hid/hid-lg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index 0dc7cdfc56f77..b6b6ed9834c7c 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -832,7 +832,7 @@ static int lg_probe(struct hid_device *hdev, const struct hid_device_id *id)

/* Select random Address */
buf[1] = 0xB2;
- get_random_bytes(&buf[2], 2);
+ prandom_bytes(buf+2, 2);

ret = hid_hw_raw_request(hdev, buf[0], buf, sizeof(cbuf),
HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
--
2.26.0