There's no need to get_random_bytes() into a temporary buffer.
This is not a no-brainer change; get_random_u32() has slightly weaker
security guarantees, but they're fine for applications like these where
the random value is stored in the kernel for as long as it's
valuable.
Signed-off-by: George Spelvin <[email protected]>
Cc: Karsten Keil <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/isdn/mISDN/tei.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/isdn/mISDN/tei.c b/drivers/isdn/mISDN/tei.c
index 59d28cb19738e..8135e20a667cc 100644
--- a/drivers/isdn/mISDN/tei.c
+++ b/drivers/isdn/mISDN/tei.c
@@ -404,10 +404,7 @@ dl_unit_data(struct manager *mgr, struct sk_buff *skb)
static unsigned int
random_ri(void)
{
- u16 x;
-
- get_random_bytes(&x, sizeof(x));
- return x;
+ return get_random_u32() & 0xffff;
}
static struct layer2 *
--
2.26.0